Skip to content

Commit

Permalink
Remove FairlearnDashboard and replace it with matplotlib-based plots (#…
Browse files Browse the repository at this point in the history
…766)

With a slight delay (originally targeted for April) I'm finally removing the `FairlearnDashboard` since a newer version already exists in `raiwidgets`. The documentation is updated to instead use the plots @MiroDudik created with a single line directly from the `MetricFrame`. In the future we want to add more kinds of plots as already mentioned in #758 #666 and #668 . Specifically, the model comparison plots do not yet have a replacement yet.

Note that the "example" added to the `examples` directory is not shown under "Example notebooks" on the webpage, which is intentional since it's technically not a notebook.

This also makes #561 mostly redundant, which I'll close shortly. 
#667 is also directly addressed with this PR as the examples illustrate.

Signed-off-by: Roman Lutz <rolutz@microsoft.com>
  • Loading branch information
Roman Lutz committed May 19, 2021
1 parent a6408a5 commit a3d2516
Show file tree
Hide file tree
Showing 44 changed files with 1 addition and 4,962 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ Sample code to reproduce the problem
<!--
Please provide the following information:
- OS: [e.g. Windows]
- Browser (if you're reporting a dashboard bug in jupyter): [e.g. Edge, Firefox, Chrome, Safari]
- Browser (if you're reporting a bug in jupyter): [e.g. Edge, Firefox, Chrome, Safari]
- Python version: [e.g. 3.7.4]
- Fairlearn version: [e.g. 0.4.5 or installed from main branch in editable mode]
- version of Python packages: please run the following snippet and paste the output:
Expand Down
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,3 @@ docbuild/

# OSX directory info files
.DS_Store

# widget files
fairlearn/widget/js/node_modules/*
1 change: 0 additions & 1 deletion CODEOWNERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
/fairlearn/metrics/ @riedgar-ms @rihorn2
/fairlearn/postprocessing/ @romanlutz
/fairlearn/reductions/ @riedgar-ms @romanlutz @MiroDudik
/fairlearn/widget/ @rihorn2
/jupyter-config @rihorn2
/notebooks @romanlutz @riedgar-ms @rihorn2 @MiroDudik
/scripts @riedgar-ms @romanlutz
Expand Down
4 changes: 0 additions & 4 deletions MANIFEST.in

This file was deleted.

2 changes: 0 additions & 2 deletions devops/PR-Gate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,4 @@ jobs:
freezeArtifactStem: $(FreezeArtifactStem)
freezeFileStem: $(FreezeFileStem)

- template: templates/build-widget-job-template.yml

- template: templates/limited-installation-job-template.yml
2 changes: 0 additions & 2 deletions devops/nightly-requirements-fixed.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,3 @@ jobs:
freezeArtifactStem: $(FreezeArtifactStem)
freezeFileStem: $(FreezeFileStem)
pinRequirements: True

- template: templates/build-widget-job-template.yml
2 changes: 0 additions & 2 deletions devops/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,4 @@ jobs:
freezeArtifactStem: $(FreezeArtifactStem)
freezeFileStem: $(FreezeFileStem)

- template: templates/build-widget-job-template.yml

- template: templates/limited-installation-job-template.yml
5 changes: 0 additions & 5 deletions devops/pypi-release-new.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ stages:
freezeArtifactStem: $(freezeArtifactStem)
freezeFileStem: $(freezeFileStem)

- template: templates/build-widget-job-template.yml

- template: templates/limited-installation-job-template.yml

# ==================================================================================================
Expand Down Expand Up @@ -101,9 +99,6 @@ stages:
freezeArtifact: $(freezeArtifactName)
freezeFile: $(freezeFile)

- script: python ./scripts/build_widget.py --yarn-path /usr/local/bin/yarn
displayName: 'Build widget'

- script: python ./scripts/build_wheels.py --version-filename $(versionFilename)
displayName: 'Build wheels'

Expand Down
21 changes: 0 additions & 21 deletions devops/templates/build-widget-job-template.yml

This file was deleted.

7 changes: 0 additions & 7 deletions docs/api_reference/fairlearn.widget.rst

This file was deleted.

1 change: 0 additions & 1 deletion docs/api_reference/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,3 @@ API Reference
fairlearn.postprocessing
fairlearn.preprocessing
fairlearn.reductions
fairlearn.widget
18 changes: 0 additions & 18 deletions fairlearn/widget/__init__.py

This file was deleted.

245 changes: 0 additions & 245 deletions fairlearn/widget/_fairlearn_dashboard.py

This file was deleted.

22 changes: 0 additions & 22 deletions fairlearn/widget/_fairlearn_widget.py

This file was deleted.

Loading

0 comments on commit a3d2516

Please sign in to comment.