Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple metrics to be passed into plotting functions #667

Closed
romanlutz opened this issue Dec 31, 2020 · 2 comments
Closed

Allow multiple metrics to be passed into plotting functions #667

romanlutz opened this issue Dec 31, 2020 · 2 comments
Labels
enhancement New feature or request help wanted
Projects
Visualizations

Comments

@romanlutz
Copy link
Member

Is your feature request related to a problem? Please describe.

With #561 one can pass in only a single metric. It would be nice to extend that to pass in multiple metrics rather than just one, and plotting all of them in a series of subplots.

Describe the solution you'd like

The existing functionality could be extended to take a single metric or a list of metrics. This wouldn't even require an API change (other than the description, of course).

Describe alternatives you've considered, if relevant

Alternatively, one could also just call the existing function n times. Then you get n different plots.
@romanlutz romanlutz added enhancement New feature or request help wanted labels Dec 31, 2020
@romanlutz romanlutz mentioned this issue Jan 8, 2021
Closed
@MiroDudik
Copy link
Member

I think that there's a simple approach to cover some instances of this: #561 (comment)

@romanlutz romanlutz mentioned this issue May 3, 2021
Merged
@romanlutz
Copy link
Member Author

This is already possible now with the MetricFrame.by_group.plot.bar approach shown in #766 . Closing the issue!

riedgar-ms pushed a commit that referenced this issue May 19, 2021
Remove FairlearnDashboard and replace it with matplotlib-based plots (#…
a3d2516 
…766)

With a slight delay (originally targeted for April) I'm finally removing the `FairlearnDashboard` since a newer version already exists in `raiwidgets`. The documentation is updated to instead use the plots @MiroDudik created with a single line directly from the `MetricFrame`. In the future we want to add more kinds of plots as already mentioned in #758 #666 and #668 . Specifically, the model comparison plots do not yet have a replacement yet.

Note that the "example" added to the `examples` directory is not shown under "Example notebooks" on the webpage, which is intentional since it's technically not a notebook.

This also makes #561 mostly redundant, which I'll close shortly. 
#667 is also directly addressed with this PR as the examples illustrate.

Signed-off-by: Roman Lutz <rolutz@microsoft.com>
@romanlutz romanlutz added this to Done in Visualizations May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted
Projects
No open projects
Visualizations
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romanlutz @MiroDudik