Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid domain names generated #52

Open
jezen opened this issue May 3, 2024 · 2 comments · May be fixed by #53
Open

Invalid domain names generated #52

jezen opened this issue May 3, 2024 · 2 comments · May be fixed by #53

Comments

@jezen
Copy link

jezen commented May 3, 2024

The Faker.Company.fixupName function used in generating domain names replaces spaces with underscores.

This is invalid according to RFC 1035.

The labels must follow the rules for ARPANET host names. They must
start with a letter, end with a letter or digit, and have as interior
characters only letters, digits, and hyphen. There are also some
restrictions on the length. Labels must be 63 characters or less.
@psibi
Copy link
Member

psibi commented May 3, 2024

I would be happy to accept a PR.

jezen added a commit to jezen/fakedata that referenced this issue May 3, 2024
@jezen
Sanitise fake email domain
64b93f6 
In order to more closely conform to RFC 1035 and actually generate valid
fake emails, we only allow alphanumeric characters or hyphens in the
text output.

See: https://datatracker.ietf.org/doc/html/rfc1035#section-2.3.1

Resolves fakedata-haskell#52
@jezen jezen linked a pull request May 3, 2024 that will close this issue
Open
jezen added a commit to jezen/fakedata that referenced this issue May 3, 2024
@jezen
Sanitise fake email domain
d48464c 
In order to more closely conform to RFC 1035 and actually generate valid
fake emails, we only allow alphanumeric characters or hyphens in the
text output.

See: https://datatracker.ietf.org/doc/html/rfc1035#section-2.3.1

Resolves fakedata-haskell#52
@jezen
Copy link
Author

jezen commented May 3, 2024

@psibi Here you are: #53.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sanitise fake email domain jezen/fakedata
2 participants
@psibi @jezen