Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pwrite and pread are unsupported #390

Closed
voxik opened this issue Feb 13, 2018 · 1 comment
Closed

pwrite and pread are unsupported #390

voxik opened this issue Feb 13, 2018 · 1 comment

Comments

@voxik
Copy link
Contributor

voxik commented Feb 13, 2018

Testing against Ruby 2.5, I observe following errors:

  1) Failure:
FakeFSTest#test_pwrite_method_in_file_is_in_fake_fs_file [/builddir/build/BUILD/fakefs-0.13.1/usr/share/gems/gems/fakefs-0.13.1/test/fakefs_test.rb:1409]:
pwrite method is not available in File :(

  2) Failure:
FakeFSTest#test_pread_method_in_file_is_in_fake_fs_file [/builddir/build/BUILD/fakefs-0.13.1/usr/share/gems/gems/fakefs-0.13.1/test/fakefs_test.rb:1409]:
pread method is not available in File :(

These are going to be triggered if #389 is merged

@grosser
Copy link
Collaborator

grosser commented Feb 13, 2018

can you add them in a PR ?
... also would be nice to change wording from pread method is not available in File :( -> please add pread method to File! :)

xnox added a commit to xnox/fakefs that referenced this issue Mar 15, 2018
Fixes fakefs#390
Signed-off-by: Dimitri John Ledkov <xnox@ubuntu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants