Check conformity of all interfaces provided by fakefs to Ruby Matz distribution

[anryoshi]

Greetings
FileTest module looks a little too thin to handle what Pathname wants from him.

FakeFS.with_fresh do
      source = Pathname.new("a.txt")
      FileUtils.touch(source)
      target = Pathname.new("b.txt")
      target.make_symlink(source)
      p File.symlink?(target) # Good
      p target.symlink? # Fails with NoMethodError:  undefined method `symlink?' for FakeFS::FileTest:Module
end

Don't get the purpose of FileTest file at all, it just passes all responsibility to File module

[grosser]

idk why FileTest exists ... ask the initial author or go spelunking through git history 🤷‍♂️
PR welcome if you figure out how to fix this

[anryoshi]

idk why FileTest exists ... ask the initial author or go spelunking through git history 🤷‍♂️
PR welcome if you figure out how to fix this

Looks like it was done to conform ruby standard library https://ruby-doc.org/core-2.6.1/FileTest.html
So the good solution probably will be add missing methods and create test to check that set of methods is the same like in actual FileTest module

[grosser]

sounds good! :)

…

On Mon, Mar 11, 2019 at 11:10 PM Anton Rybakov ***@***.***> wrote: idk why FileTest exists ... ask the initial author or go spelunking through git history 🤷‍♂️ PR welcome if you figure out how to fix this Looks like it was done to conform ruby standard library https://ruby-doc.org/core-2.6.1/FileTest.html So the good solution probably will be add missing methods and create test to check that set of methods is the same like in actual FileTest module — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#430 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAsZ0TmoOwU5Qa5x7q2Zpt46e7rZ9k1ks5vV0S_gaJpZM4bpNnV> .

[anryoshi]

@grosser I've created pull request for this #431

[anryoshi]

Have renamed to represent more common goal. It will be nice to have tests that check equality the sets of methods provided by fakefs and Ruby distribution in module/classes - File, File::Stat, FileUtils, FileTests, Pathname and etc

[aried3r]

Adding to this, Ruby 2.7 does include some changes to File. I discovered this while ]working on memfs](simonc/memfs#30 (comment)). That's at least one of the changes I discovered.

To summarize:
In Ruby 2.7 File::extname returns . on non-Windows platforms.

https://docs.ruby-lang.org/en/2.7.0/File.html#method-c-extname
https://docs.ruby-lang.org/en/2.7.0/NEWS.html
https://rubyreferences.github.io/rubychanges/2.7.html#fileextname-returns-a--string-at-a-name-ending-with-a-dot