Update Ruby versions on Travis CI #30

aried3r · 2019-11-29T16:22:20Z

Let's see if this just works :)

coveralls · 2019-11-29T16:25:18Z

Coverage increased (+0.2%) to 99.779% when pulling 621b81b on aried3r:patch-1 into 26e0cb9 on simonc:master.

aried3r · 2019-11-29T16:35:16Z

Hmm, quite a long list of failures on Ruby 2.6. I'll try to have a look.

simonc · 2019-11-29T20:38:54Z

Hi @aried3r!

Thanks for opening this PR. I haven't been very active on the project for a while but I can help get it working for Ruby 2.6.

If you have any question or if you want to have a pairing session I'm available (French timezone though ^^).

Cheers !

aried3r · 2019-12-02T09:09:56Z

Ok, so some of the failures are indeed because of changes in Ruby 2.6.

Ruby 2.6 includes version 1.1 of the fileutils gem, which includes this change: ruby/fileutils#13. fileutils is now a stdgem (https://stdgems.org/), but I think that's unrelated. In this case, I'd just adopt the expected result if RUBY_VERSION >= 2.6, WDYT?

The errors related to missing children are because of the addition of Dir.children, however I haven't looked into it how exactly this gem is using this, directly or indirectly, especially since it fails on MemFs::Dir. Maybe you can shed some light on how to best fix this?

ruby/fileutils@d8c665c
ruby/fileutils@bc92c93

simonc · 2019-12-03T23:10:05Z

@aried3r The condition on RUBY_VERSION seems to be a sensible choice. I don't see a more explicit solution for this issue.

Regarding the missing children method it's failing on MemFs::Dir because it's the class replacing the original Ruby Dir class when MemFs is enabled. I think the next step is to implement this method in MemFs::Dir.

The only interrogation I have is if we should condition this method's definition with if RUBY_VERSION >= 2.6 🤔

My pro argument is that it would prevent this method from being defined in earlier versions and thus prevent unwanted effects in users specs.

My con argument is that no other method was conditioned by the current Ruby version before so I'm not sure it'd make sense to do it in this specific occasion.

What's your opinion on that matter?

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout

.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout

.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

aried3r · 2020-01-02T09:37:00Z

Hey! Seems like I pushed some changes but never followed up here. So I added the necessary methods and also made them dependent on the Ruby version installed. WDYT?

simonc

@aried3r Thank you! I added some comments on the PR 😊

.travis.yml

lib/memfs/dir.rb

simonc · 2020-01-06T15:41:58Z

spec/memfs/dir_spec.rb

+    if Gem::Requirement.new('>= 2.6').satisfied_by?(Gem::Version.new(RUBY_VERSION))
+      describe '.children' do
+        it 'returns an array containing all of the filenames except for "." and ".."'\
+            'in this directory.' do


Don't worry about line length for specs descriptions. I exluded the spec files from rubocop to avoid having this weird cuts 😄

simonc · 2020-01-06T15:42:42Z

spec/memfs/dir_spec.rb

+      end
+    else
+      describe '.children' do
+        it 'raises and error' do


I think you meant an error 😊

Good catch, thanks!

simonc · 2020-01-06T15:42:48Z

spec/memfs/dir_spec.rb

+    if Gem::Requirement.new('>= 2.6').satisfied_by?(Gem::Version.new(RUBY_VERSION))
+      describe '.children' do
+        it 'returns an array containing all of the filenames except for "." and ".."'\
+            'in this directory.' do


Don't worry about line length for specs descriptions. I excluded the spec files from rubocop to avoid having this weird cuts 😄

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout

.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

aried3r · 2020-01-07T07:41:44Z

I knew I shouldn't have removed EOL Rubies and added Ruby 2.7 in one commit 😅

Now it gets interesting. In Ruby 2.7 File::extname returns . on non-Windows platforms. Do you want to handle this case (if Ruby >= 2.7 && !Windows (https://github.com/ruby/ruby/pull/2565/files#diff-01bda6262e55b3f376e1fd6ad669f78aR242))?

https://docs.ruby-lang.org/en/2.7.0/File.html#method-c-extname
https://docs.ruby-lang.org/en/2.7.0/NEWS.html
https://rubyreferences.github.io/rubychanges/2.7.html#fileextname-returns-a--string-at-a-name-ending-with-a-dot

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout

.rubocop.yml: Style/AlignParameters has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/FileName has the wrong namespace - should be Naming
.rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming
.rubocop.yml: Style/MultilineOperationIndentation has the wrong namespace - should be Layout
Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in .rubocop.yml, please update it)
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead

spec/memfs/file_spec.rb

aried3r · 2020-01-07T08:03:07Z

I added the Ruby 2.7 behavior of File::extname to the specs.

spec/memfs/file_spec.rb

simonc · 2020-01-07T10:43:54Z

@aried3r Thanks for your work on this! ❤️

Update Ruby versions on Travis CI

78ca289

Implement MemFs::Dir#children

82c8c77

houndci-bot reviewed Dec 11, 2019

View reviewed changes

Make spec dependent on Ruby version

5419641

houndci-bot reviewed Dec 11, 2019

View reviewed changes

simonc requested changes Jan 6, 2020

View reviewed changes

aried3r added 3 commits January 7, 2020 08:05

Test with Ruby 2.7, stop testing w/ EOL rubies

757b2ee

Fix RSpec it-messages

c711622

Add MemFs.ruby_version_gte?

9d97e17

houndci-bot reviewed Jan 7, 2020

View reviewed changes

aried3r mentioned this pull request Jan 7, 2020

Check conformity of all interfaces provided by fakefs to Ruby Matz distribution fakefs/fakefs#430

Open

File::extname Ruby 2.7 behavior

621b81b

houndci-bot reviewed Jan 7, 2020

View reviewed changes

aried3r commented Jan 7, 2020

View reviewed changes

spec/memfs/file_spec.rb Show resolved Hide resolved

simonc approved these changes Jan 7, 2020

View reviewed changes

spec/memfs/file_spec.rb Show resolved Hide resolved

simonc merged commit d8e61ab into simonc:master Jan 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Ruby versions on Travis CI #30

Update Ruby versions on Travis CI #30

aried3r commented Nov 29, 2019

coveralls commented Nov 29, 2019 •

edited

aried3r commented Nov 29, 2019

simonc commented Nov 29, 2019

aried3r commented Dec 2, 2019

simonc commented Dec 3, 2019 •

edited

houndci-bot left a comment

houndci-bot left a comment

aried3r commented Jan 2, 2020

simonc left a comment

simonc Jan 6, 2020

simonc Jan 6, 2020

aried3r Jan 7, 2020

simonc Jan 6, 2020

houndci-bot left a comment

aried3r commented Jan 7, 2020 •

edited

houndci-bot left a comment

aried3r commented Jan 7, 2020

simonc commented Jan 7, 2020

Update Ruby versions on Travis CI #30

Update Ruby versions on Travis CI #30

Conversation

aried3r commented Nov 29, 2019

coveralls commented Nov 29, 2019 • edited

aried3r commented Nov 29, 2019

simonc commented Nov 29, 2019

aried3r commented Dec 2, 2019

simonc commented Dec 3, 2019 • edited

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

aried3r commented Jan 2, 2020

simonc left a comment

Choose a reason for hiding this comment

simonc Jan 6, 2020

Choose a reason for hiding this comment

simonc Jan 6, 2020

Choose a reason for hiding this comment

aried3r Jan 7, 2020

Choose a reason for hiding this comment

simonc Jan 6, 2020

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

aried3r commented Jan 7, 2020 • edited

houndci-bot left a comment

Choose a reason for hiding this comment

aried3r commented Jan 7, 2020

simonc commented Jan 7, 2020

coveralls commented Nov 29, 2019 •

edited

simonc commented Dec 3, 2019 •

edited

aried3r commented Jan 7, 2020 •

edited