simplify gemspec and ship less files #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,14 +6,11 @@ Gem::Specification.new do |spec| | |||
| spec.authors = ["Chris Wanstrath", "Scott Taylor", "Jeff Hodges", "Pat Nakajima", "Brian Donovan"] | |||
| spec.email = ["chris@ozmm.org"] | |||
| spec.description = %q{A fake filesystem. Use it in your tests.} | |||
| spec.summary = %q{A fake filesystem. Use it in your tests.} | |||
| spec.homepage = "http://github.com/defunkt/fakefs" | |||
| spec.summary = spec.description | |||
There was a problem hiding this comment.
Are both summary and description necessary? Would it be better to leave out one of them than simply duplicating?
There was a problem hiding this comment.
without description WARNING: no description specified
without summary ERROR: While executing gem ... (Gem::InvalidSpecificationException) missing value for attribute summary
so no :)
|
Looks good 👍 |
| spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) } | ||
| spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) | ||
| spec.require_paths = ["lib"] | ||
| spec.files = `git ls-files lib README.markdown LICENSE`.split($/) |
There was a problem hiding this comment.
Generally it is a good idea to also ship tests with a gem. Package maintainers of Linux distributions usually run tests as a part of the distro package building process.
See the Debian Ruby packaging team's notes on testing for an example.
There was a problem hiding this comment.
- all users will directly benefit from the smaller payload + smaller git size when vendored
- Installing gems via packages is weird / uncommon -> very little impact
- Most test suites do not run without proper bundling/setup so maintainers most likely cannot run them anyway
- Lots of popular libraries do not sip test files -> if rails does not do it, we don't need to either
grosser
added a commit
that referenced
this pull request
Feb 3, 2016
simplify gemspec and ship less files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@smtlaissezfaire @eventualbuddha