Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Address module to Location #1344

Closed
ST-DDT opened this issue Sep 6, 2022 · 4 comments · Fixed by #1469
Closed

Rename Address module to Location #1344

ST-DDT opened this issue Sep 6, 2022 · 4 comments · Fixed by #1469
Assignees
@Shinigami92
Labels
breaking change Cannot be merged when next version is not a major release c: feature Request for new feature c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: location Something is referring to the location module p: 1-normal Nothing urgent s: on hold Blocked by something or frozen to avoid conflicts
Milestone
v8.0 - Module Re-...

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Sep 6, 2022 •
edited
Loading

Clear and concise description of the problem

The address module contains more than just addresses.

Suggested solution

  • Rename the module to Location so it is clear that this contains also general location related methods.
  • The Address module is degraded to an alias for two major versions

Alternative

No response

Additional context

No response
@ST-DDT ST-DDT added c: feature Request for new feature s: on hold Blocked by something or frozen to avoid conflicts p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release m: location Something is referring to the location module labels Sep 6, 2022
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Sep 6, 2022
@ST-DDT
Copy link
Member Author

ST-DDT commented Sep 6, 2022

See also #805

@ST-DDT
Copy link
Member Author

ST-DDT commented Sep 6, 2022

Blocked by #932 / #1291

@ST-DDT
Copy link
Member Author

ST-DDT commented Sep 6, 2022 •
edited
Loading

Blocked by #1183

@ST-DDT ST-DDT mentioned this issue Sep 6, 2022
Closed
@Shinigami92
Copy link
Member

I'm interested in being the champion of this (creating the PR when it's ready to start it)

@Shinigami92 Shinigami92 mentioned this issue Sep 9, 2022
Closed
@ST-DDT ST-DDT added s: on hold Blocked by something or frozen to avoid conflicts and removed s: on hold Blocked by something or frozen to avoid conflicts labels Oct 12, 2022
This was referenced Oct 13, 2022
Merged
Merged
Merged
@Shinigami92 Shinigami92 linked a pull request Oct 18, 2022 that will close this issue
refactor(location)!: rename address module #1469
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shinigami92 Shinigami92

Labels
breaking change Cannot be merged when next version is not a major release c: feature Request for new feature c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: location Something is referring to the location module p: 1-normal Nothing urgent s: on hold Blocked by something or frozen to avoid conflicts
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging a pull request may close this issue.

refactor(location)!: rename address module faker-js/faker
2 participants
@ST-DDT @Shinigami92