Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(location)!: rename address module #1469

Merged
merged 11 commits into from
Oct 21, 2022

Conversation

Shinigami92
Copy link
Member

closes #1344

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release m: location Something is referring to the location module labels Oct 18, 2022
@Shinigami92 Shinigami92 self-assigned this Oct 18, 2022
@Shinigami92 Shinigami92 linked an issue Oct 18, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #1469 (cc24a01) into next (02f3967) will decrease coverage by 0.00%.
The diff coverage is 93.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1469      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files        2165     2165              
  Lines      237104   237132      +28     
  Branches     1015     1016       +1     
==========================================
+ Hits       236229   236242      +13     
- Misses        854      869      +15     
  Partials       21       21              
Impacted Files Coverage Δ
src/definitions/definitions.ts 0.00% <0.00%> (ø)
src/definitions/index.ts 0.00% <0.00%> (ø)
src/definitions/location.ts 0.00% <0.00%> (ø)
src/locales/af_ZA/location/default_country.ts 100.00% <ø> (ø)
src/locales/af_ZA/location/postcode.ts 100.00% <ø> (ø)
src/locales/ar/location/building_number.ts 100.00% <ø> (ø)
src/locales/ar/location/city_name.ts 100.00% <ø> (ø)
src/locales/ar/location/country.ts 100.00% <ø> (ø)
src/locales/ar/location/default_country.ts 100.00% <ø> (ø)
src/locales/ar/location/postcode.ts 100.00% <ø> (ø)
... and 1073 more

@Shinigami92
Copy link
Member Author

In e7961b0 I didn't touched the address tests, so everything was green
Will now rename them

@Shinigami92 Shinigami92 marked this pull request as ready for review October 18, 2022 20:37
@Shinigami92 Shinigami92 requested a review from a team October 18, 2022 20:37
@Shinigami92 Shinigami92 requested a review from a team as a code owner October 18, 2022 20:37
@Shinigami92 Shinigami92 requested a review from a team October 18, 2022 20:37
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: ST-DDT <ST-DDT@gmx.de>
@Shinigami92
Copy link
Member Author

@ST-DDT Nice catches, thx 🙂

ST-DDT
ST-DDT previously approved these changes Oct 19, 2022
import-brain
import-brain previously approved these changes Oct 20, 2022
@ST-DDT ST-DDT requested review from a team October 20, 2022 07:54
@xDivisionByZerox
Copy link
Member

Should we update this as well?

refactor(address): deprecate streetPrefix and streetSuffix

@Shinigami92 Shinigami92 merged commit b983ca1 into next Oct 21, 2022
@ST-DDT ST-DDT deleted the 1344-rename-address-module-to-location branch October 21, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Rename Address module to Location
4 participants