Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate example values for string module #1468

Closed
ST-DDT opened this issue Oct 18, 2022 · 1 comment · Fixed by #1473
Closed

Regenerate example values for string module #1468

ST-DDT opened this issue Oct 18, 2022 · 1 comment · Fixed by #1473
Assignees
@import-brain
Labels
c: docs Improvements or additions to documentation m: string Something is referring to the string module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v8.0 - Module Re-...

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Oct 18, 2022

The examples values for each call have been copied from the original place where case = lower was the default.
The examples should be regenerated to reflect that and other changes.

can be started after #1155
@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug m: string Something is referring to the string module labels Oct 18, 2022
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Oct 18, 2022
@import-brain
Copy link
Member

I can take this one

@import-brain import-brain mentioned this issue Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@import-brain import-brain

Labels
c: docs Improvements or additions to documentation m: string Something is referring to the string module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging a pull request may close this issue.

docs(string): update function jsdocs faker-js/faker
2 participants
@ST-DDT @import-brain