Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(string): update function jsdocs #1473

Merged
merged 1 commit into from Oct 20, 2022
Merged

docs(string): update function jsdocs #1473

merged 1 commit into from Oct 20, 2022

Conversation

import-brain
Copy link
Member

closes #1468

@import-brain import-brain added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug m: string Something is referring to the string module labels Oct 18, 2022
@import-brain import-brain self-assigned this Oct 18, 2022
@import-brain import-brain requested a review from a team as a code owner October 18, 2022 23:53
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #1473 (9729c29) into next (79858fe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1473   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2165     2165           
  Lines      237100   237104    +4     
  Branches     1015     1019    +4     
=======================================
+ Hits       236225   236247   +22     
+ Misses        854      836   -18     
  Partials       21       21
Impacted Files Coverage Δ
src/modules/string/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 87.83% <0.00%> (+4.76%) ⬆️

@ST-DDT ST-DDT merged commit 02f3967 into next Oct 20, 2022
@ST-DDT ST-DDT deleted the docs/update_string_jsdocs branch October 20, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@import-brain import-brain

Labels
c: docs Improvements or additions to documentation m: string Something is referring to the string module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

Regenerate example values for string module
4 participants
@import-brain @ST-DDT @Shinigami92 @xDivisionByZerox