mersenne.rand without min argument returns NaN

[piotrekn]

Describe the bug

This is buggy, cause if min is not passed but only max, then min will be undefined and this result in NaN for the whole function

faker/src/mersenne.ts

Lines 31 to 40 in 30b0faa

	rand(max?: number, min?: number): number {
	// TODO @Shinigami92 2022-01-11: This is buggy, cause if min is not passed but only max,
	// then min will be undefined and this result in NaN for the whole function
	if (max === undefined) {
	min = 0;
	max = 32768;
	}
	return Math.floor(this.gen.genrand_real2() * (max - min) + min);
	}

Reproduction

new Mersenne().rand(1);

This should return 0 no matter the seed, but returns NaN.

Additional Info

No response

[xDivisionByZerox]

I want to do this. Please assign me.

[xDivisionByZerox]

I also implemented an if statement that checks if min > max in which case it throws an error. This behavior is breaking 83 test in 4 suits.

What would the expected behavior be here?

[ST-DDT]

I also implemented an if statement that checks if min > max in which case it throws an error. This behavior is breaking 83 test in 4 suits.

What would the expected behavior be here?

Not sure on this one. I tend to allow min and max to be swapped as a kind of undocumented convenience feature.

[piotrekn]

If mersenne.rand does not bother the min-max swap, should it thrown an error? To maintain the semantic meaning consider swapping values instead.

[xDivisionByZerox]

FYI: Swapping the values will not break any existing test cases.