Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mersenne rand invalid input argument #577

Merged
merged 3 commits into from
Mar 21, 2022
Merged

fix: mersenne rand invalid input argument #577

merged 3 commits into from
Mar 21, 2022

Conversation

xDivisionByZerox
Copy link
Member

Created in relation to #479

@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner February 26, 2022 22:24
@codecov
Copy link

codecov bot commented Feb 26, 2022

Codecov Report

Merging #577 (d7ca0e1) into main (5a15c40) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d7ca0e1 differs from pull request most recent head 6388b4e. Consider uploading reports for the commit 6388b4e to get more accurate results

@@           Coverage Diff           @@
##             main     #577   +/-   ##
=======================================
  Coverage   99.33%   99.33%           
=======================================
  Files        1920     1920           
  Lines      176482   176443   -39     
  Branches      905      898    -7     
=======================================
- Hits       175302   175264   -38     
+ Misses       1124     1123    -1     
  Partials       56       56           
Impacted Files Coverage Δ
src/mersenne.ts 100.00% <100.00%> (ø)
src/image_providers/lorempicsum.ts 93.96% <0.00%> (-0.48%) ⬇️
src/image_providers/lorempixel.ts 91.75% <0.00%> (-0.23%) ⬇️
src/system.ts 96.37% <0.00%> (-0.11%) ⬇️
src/image_providers/unsplash.ts 98.66% <0.00%> (-0.06%) ⬇️
src/date.ts 100.00% <0.00%> (ø)
src/iban.ts 100.00% <0.00%> (ø)
src/definitions/utils.ts 100.00% <0.00%> (ø)
src/finance.ts 99.32% <0.00%> (+<0.01%) ⬆️
src/helpers.ts 99.25% <0.00%> (+0.12%) ⬆️

@import-brain import-brain added the c: bug Something isn't working label Feb 26, 2022
@ST-DDT ST-DDT linked an issue Feb 27, 2022 that may be closed by this pull request
ST-DDT
ST-DDT previously approved these changes Feb 27, 2022
@ST-DDT ST-DDT requested a review from a team February 27, 2022 00:30
prisis
prisis previously approved these changes Mar 1, 2022
@xDivisionByZerox xDivisionByZerox changed the title Fix/mersenne rand invalid input argument fix: mersenne rand invalid input argument Mar 1, 2022
@Shinigami92
Copy link
Member

Could we add somehow documentation for the new added behaviour? Or is it intentionally undocumented?

@ST-DDT
Copy link
Member

ST-DDT commented Mar 10, 2022

Could we add somehow documentation for the new added behaviour? Or is it intentionally undocumented?

IMO there is no need, this PR only added the defaults, the min/max swap doesn't have any impact AFAICT.

@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Mar 15, 2022
@ST-DDT ST-DDT dismissed stale reviews from prisis and themself via dd88f5b March 21, 2022 10:05
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 21, 2022 13:13
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 21, 2022
@Shinigami92 Shinigami92 merged commit 486c76e into faker-js:main Mar 21, 2022
@ST-DDT ST-DDT mentioned this pull request Apr 5, 2022
@xDivisionByZerox xDivisionByZerox deleted the fix/mersenne-rand-invalid-input-argument branch April 15, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mersenne.rand without min argument returns NaN
5 participants