Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(name): use single quotes in examples and English as result #1167

Merged
merged 2 commits into from Jul 19, 2022
Merged

docs(name): use single quotes in examples and English as result #1167

merged 2 commits into from Jul 19, 2022

Conversation

hankucz
Copy link
Contributor

@hankucz hankucz commented Jul 19, 2022

No description provided.

@hankucz hankucz requested a review from a team as a code owner July 19, 2022 11:02
@xDivisionByZerox xDivisionByZerox changed the title docs: update examples to use single quotes for strings and English as a result docs(name): update examples to use single quotes for strings and English as a result Jul 19, 2022
@xDivisionByZerox xDivisionByZerox added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Jul 19, 2022
@xDivisionByZerox xDivisionByZerox added this to the v7 - Current Major milestone Jul 19, 2022
@ST-DDT ST-DDT requested review from a team July 19, 2022 11:55
@codecov
Copy link

codecov bot commented Jul 19, 2022 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (main@0a2ec9d). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 542c8a7 differs from pull request most recent head ccd591e. Consider uploading reports for the commit ccd591e to get more accurate results

@@           Coverage Diff           @@
##             main    #1167   +/-   ##
=======================================
  Coverage        ?   99.64%           
=======================================
  Files           ?     2146           
  Lines           ?   230462           
  Branches        ?      980           
=======================================
  Hits            ?   229652           
  Misses          ?      789           
  Partials        ?       21
Impacted Files Coverage Δ
src/modules/name/index.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT changed the title docs(name): update examples to use single quotes for strings and English as a result docs(name): use single quotes in examples and English as result Jul 19, 2022
@ST-DDT ST-DDT enabled auto-merge (squash) July 19, 2022 11:57
@ST-DDT ST-DDT merged commit 0bd2f39 into faker-js:main Jul 19, 2022
@xDivisionByZerox xDivisionByZerox added the m: person Something is referring to the person module label Jul 28, 2022
@hankucz hankucz deleted the docfix branch August 3, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@hankucz hankucz

Labels
c: docs Improvements or additions to documentation m: person Something is referring to the person module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hankucz @ST-DDT @Shinigami92 @xDivisionByZerox