docs(finance): ethereumAddress returns non checksummed addresses #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: docs
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1650 +/- ##
==========================================
- Coverage 99.64% 99.64% -0.01%
==========================================
Files 2221 2221
Lines 240108 240110 +2
Branches 1053 1051 -2
==========================================
- Hits 239260 239248 -12
- Misses 827 841 +14
Partials 21 21
|
Shinigami92
approved these changes
Dec 9, 2022
import-brain
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1567
Supersedes #1578
It is not possible to implement #1578 for now.
This PR adds some JSdocs clarifying the nature of the returned address instead.
We can reevaluate the option to generate checksummed addresses when all supported node versions support the required hash(?) algorithm.