chore: auto-build lib folder before running tests #188
Conversation
|
✔️ Deploy Preview for vigilant-wescoff-04e480 ready! 🔨 Explore the source changes: 1edaf23 🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e4e0477061be0008133c5f 😎 Browse the preview: https://deploy-preview-188--vigilant-wescoff-04e480.netlify.app |
clarkerican
force-pushed
the
erica/build-lib-pretest
branch
from
c6698f9
to
1edaf23
Compare
| @@ -17,7 +17,6 @@ jobs: | |||
| node-version: '16' | |||
| cache: 'npm' | |||
| - run: npm ci | |||
| - run: npm run build | |||
There was a problem hiding this comment.
I could leave this in just to be safe and explicit.
There was a problem hiding this comment.
In #153 I introduced a common pattern like <task>:ci, I think I will change that to ci:<task> today!
So instead of having a pretest that could mess-up stuff or just run stuff twice without wanted, we could simply have a "ci:test": "run-s build test" and link that in ci.yml
|
@clarkerican I think that the docs have been updated to cover the scenario you ran into. I'm going to close this PR for now unless the |
Issue #187