Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: extend Faker class jsdocs #1960

Merged
merged 9 commits into from Mar 27, 2023
Merged

docs: extend Faker class jsdocs #1960

merged 9 commits into from Mar 27, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 22, 2023

Extracted from #1940 to make it easier to review.

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 22, 2023
@ST-DDT ST-DDT requested review from a team March 22, 2023 10:24
@ST-DDT ST-DDT self-assigned this Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 22, 2023 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (next@17f0488). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7abc61b differs from pull request most recent head c46acc0. Consider uploading reports for the commit c46acc0 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1960   +/-   ##
=======================================
  Coverage        ?   99.63%           
=======================================
  Files           ?     2384           
  Lines           ?   239167           
  Branches        ?     1229           
=======================================
  Hits            ?   238290           
  Misses          ?      855           
  Partials        ?       22

@ST-DDT ST-DDT mentioned this pull request Mar 22, 2023
Merged
matthewmayer
matthewmayer requested changes Mar 22, 2023
View reviewed changes
src/faker.ts Show resolved Hide resolved
src/faker.ts Show resolved Hide resolved
src/faker.ts Outdated Show resolved Hide resolved
xDivisionByZerox
xDivisionByZerox reviewed Mar 22, 2023
View reviewed changes
src/faker.ts Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 reviewed Mar 22, 2023
View reviewed changes
src/faker.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested review from Shinigami92, xDivisionByZerox and a team March 22, 2023 19:23
Shinigami92
Shinigami92 previously approved these changes Mar 22, 2023
View reviewed changes
@ST-DDT ST-DDT mentioned this pull request Mar 22, 2023
Merged
@ST-DDT ST-DDT requested review from Shinigami92 and a team March 22, 2023 20:31
@ST-DDT ST-DDT requested a review from a team March 23, 2023 08:23
@ST-DDT ST-DDT enabled auto-merge (squash) March 27, 2023 11:16
@ST-DDT ST-DDT merged commit 4a3a6b9 into next Mar 27, 2023
15 checks passed
@Shinigami92 Shinigami92 deleted the docs/faker-class branch March 27, 2023 11:22
@ST-DDT ST-DDT mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox Awaiting requested review from xDivisionByZerox

Assignees

@ST-DDT ST-DDT

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ST-DDT @matthewmayer @Shinigami92 @xDivisionByZerox