Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mark deprecated parameter options #1962

Merged
merged 7 commits into from Mar 24, 2023
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 22, 2023

Created based on: #1960 (comment) and might be useful for #1919 as well.

Since we have switched from multiple parameters to a single options params, it is likely that we get deprecated options in the future.
This PR adds a DEPRECATED: prefix to deprecated parameter options to increase visibility of these parameters in the docs..

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Mar 22, 2023
@ST-DDT ST-DDT requested review from a team March 22, 2023 20:21
@ST-DDT ST-DDT self-assigned this Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #1962 (1c833ed) into next (9dcf83f) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1962   +/-   ##
=======================================
  Coverage   99.63%   99.64%           
=======================================
  Files        2384     2384           
  Lines      238992   238992           
  Branches     1230     1235    +5     
=======================================
+ Hits       238123   238140   +17     
+ Misses        847      830   -17     
  Partials       22       22           

see 1 file with indirect coverage changes

@ST-DDT
Copy link
Member Author

ST-DDT commented Mar 22, 2023

Here a (faked) visual example:

grafik

@ST-DDT ST-DDT requested a review from a team March 22, 2023 22:38
@matthewmayer
Copy link
Contributor

How about also adding some strikethrough on the parameter name?
image

@ST-DDT
Copy link
Member Author

ST-DDT commented Mar 23, 2023

How about also adding some strikethrough on the parameter name? image

Done

@ST-DDT ST-DDT enabled auto-merge (squash) March 24, 2023 09:05
@ST-DDT ST-DDT merged commit 16383bb into next Mar 24, 2023
17 checks passed
@ST-DDT ST-DDT deleted the docs/deprecated-parameter-options branch March 24, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants