Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(business): remove old business data #2033

Merged
merged 3 commits into from Apr 12, 2023
Merged

chore(business): remove old business data #2033

merged 3 commits into from Apr 12, 2023

Conversation

matthewmayer
Copy link
Contributor

Removes unused and old definitions for which there are better alternative methods.
Documents the removal.
Tweaks tests.

@matthewmayer matthewmayer requested a review from a team April 9, 2023 17:54
@matthewmayer matthewmayer requested a review from a team as a code owner April 9, 2023 17:54
@matthewmayer matthewmayer self-assigned this Apr 9, 2023
@matthewmayer matthewmayer added c: chore PR that doesn't affect the runtime behavior c: locale Permutes locale definitions breaking change Cannot be merged when next version is not a major release m: finance Something is referring to the finance module p: 1-normal Nothing urgent labels Apr 9, 2023
@codecov
Copy link

codecov bot commented Apr 9, 2023 •
edited

Codecov Report

Merging #2033 (b80f1fa) into next (8363dd3) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head b80f1fa differs from pull request most recent head 1d5dd98. Consider uploading reports for the commit 1d5dd98 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2033   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files        2545     2535   -10     
  Lines      241648   241584   -64     
  Branches     1282     1284    +2     
=======================================
- Hits       240717   240663   -54     
+ Misses        904      894   -10     
  Partials       27       27
Impacted Files Coverage Δ
src/locales/el/index.ts 100.00% <ø> (ø)
src/locales/en/index.ts 100.00% <ø> (ø)
src/locales/ur/index.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT requested review from a team April 11, 2023 11:22
@ST-DDT ST-DDT requested a review from a team April 12, 2023 07:35
@ST-DDT ST-DDT enabled auto-merge (squash) April 12, 2023 15:27
@ST-DDT ST-DDT disabled auto-merge April 12, 2023 15:28
@ST-DDT ST-DDT enabled auto-merge (squash) April 12, 2023 15:29
@ST-DDT ST-DDT merged commit 1abf31b into faker-js:next Apr 12, 2023
15 checks passed
@xDivisionByZerox xDivisionByZerox mentioned this pull request Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@import-brain import-brain import-brain approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@matthewmayer matthewmayer

Labels
breaking change Cannot be merged when next version is not a major release c: chore PR that doesn't affect the runtime behavior c: locale Permutes locale definitions m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewmayer @ST-DDT @import-brain @xDivisionByZerox