Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(phone): improve deprecation and see message #2517

Merged
merged 2 commits into from Oct 31, 2023
Merged

docs(phone): improve deprecation and see message #2517

merged 2 commits into from Oct 31, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 30, 2023

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent m: phone Something is referring to the phone module labels Oct 30, 2023
@ST-DDT ST-DDT added this to the v8.x milestone Oct 30, 2023
@ST-DDT ST-DDT requested review from a team October 30, 2023 13:42
@ST-DDT ST-DDT self-assigned this Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited

Codecov Report

Merging #2517 (f09423d) into next (2d591de) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2517   +/-   ##
=======================================
  Coverage   99.58%   99.59%           
=======================================
  Files        2823     2823           
  Lines      255497   255507   +10     
  Branches     1102     1105    +3     
=======================================
+ Hits       254434   254469   +35     
+ Misses       1035     1010   -25     
  Partials       28       28
Files Coverage Δ
src/modules/phone/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT @xDivisionByZerox
Update src/modules/phone/index.ts
f09423d 
Co-authored-by: DivisionByZero <leyla.jaehnig@gmx.de>
@xDivisionByZerox xDivisionByZerox merged commit 18bbc3a into next Oct 31, 2023
20 checks passed
@xDivisionByZerox xDivisionByZerox deleted the docs/phone/add-see-and-deprecation branch October 31, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@import-brain import-brain import-brain approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: docs Improvements or additions to documentation m: phone Something is referring to the phone module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Improve deprecation message for faker.phone.number(format)
3 participants
@ST-DDT @import-brain @xDivisionByZerox