Improve deprecation message for faker.phone.number(format)

[matthewmayer]

          > It would be nice if at least a few options were available before the deprecation took effect. We have an simple use case like `faker.phone.number('##########')`, which I think would be hard to replicate until this is complete?

the direct replacement for faker.phone.number('##########') is faker.helpers.replaceSymbolWithNumber('##########') - maybe the deprecation message should be modified to make that clearer?

Originally posted by @matthewmayer in #1542 (comment)

[ST-DDT]

FFR:

faker/src/modules/phone/index.ts

Line 37 in 005369b

* @deprecated Use `faker.phone.number()` without an argument instead.

faker/src/modules/phone/index.ts

Lines 52 to 59 in 005369b

	if (format != null) {
	deprecated({
	deprecated: 'faker.phone.number(format)',
	proposed: 'faker.phone.number()',
	since: '8.1',
	until: '9.0',
	});
	}

[ST-DDT]

This should potentially list faker.numeric() and faker.helpers.fromRegexp() as alternatives.

[brandon-pereira]

I had faker.phone.number("+1 (403) ###-####"), and I use the phone package to validate phone numbers. After removing the formatter, phone numbers like 347.494.6136 x4935 which are returned were failing the validation, so I ended up using faker.helpers.replaceSymbolWithNumber("+1 (403) ###-####") instead and it seems to work, but YMMV

[ST-DDT]

Team Decision

• We will implement this for v8.2