Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: IBAN library typed and moved to utils #785

Merged
merged 5 commits into from
Apr 6, 2022
Merged

chore: IBAN library typed and moved to utils #785

merged 5 commits into from
Apr 6, 2022

Conversation

pkuczynski
Copy link
Member

No description provided.

@pkuczynski pkuczynski added the c: chore PR that doesn't affect the runtime behavior label Apr 5, 2022
@pkuczynski pkuczynski added this to the v6 - Non-Breaking Changes milestone Apr 5, 2022
@pkuczynski pkuczynski self-assigned this Apr 5, 2022
@pkuczynski pkuczynski requested a review from a team as a code owner April 5, 2022 22:49
ST-DDT
ST-DDT reviewed Apr 5, 2022
View reviewed changes
src/utils/iban.ts Outdated Show resolved Hide resolved
@pkuczynski pkuczynski requested review from ST-DDT and a team April 5, 2022 23:25
@codecov
Copy link

codecov bot commented Apr 5, 2022 •
edited
Loading

Codecov Report

Merging #785 (2dcc889) into main (a8970bd) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2dcc889 differs from pull request most recent head f7ac924. Consider uploading reports for the commit f7ac924 to get more accurate results

@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1921     1921              
  Lines      176695   176662      -33     
  Branches      910      904       -6     
==========================================
- Hits       175542   175509      -33     
  Misses       1097     1097              
  Partials       56       56
Impacted Files Coverage Δ
src/finance.ts 99.28% <100.00%> (-0.05%) ⬇️
src/utils/iban.ts 100.00% <100.00%> (ø)
src/database.ts 100.00% <0.00%> (ø)
src/locales/zh_CN/name/last_name.ts 100.00% <0.00%> (ø)

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Apr 6, 2022
@ST-DDT ST-DDT requested a review from a team April 6, 2022 07:48
@Shinigami92 Shinigami92 enabled auto-merge (squash) April 6, 2022 08:26
@Shinigami92 Shinigami92 merged commit 3e5aaf1 into main Apr 6, 2022
@Shinigami92 Shinigami92 deleted the iban-lib-typed branch April 6, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@pkuczynski pkuczynski

Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v6.2 - New small features
Development

Successfully merging this pull request may close these issues.
3 participants
@pkuczynski @ST-DDT @Shinigami92