-
-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename helpers to helper #933
Conversation
Codecov Report
@@ Coverage Diff @@
## main #933 +/- ##
=======================================
Coverage 99.66% 99.66%
=======================================
Files 1957 1957
Lines 209831 209831
Branches 891 890 -1
=======================================
+ Hits 209121 209134 +13
+ Misses 690 678 -12
+ Partials 20 19 -1
|
I like |
I had the exact same thought! 🤔 |
I don't like both names :) We should keep the whole thing private and used only internally, move things like |
Do you have an alternative? Is
Not sure about that. Some of the methods maybe, but I assume some will be left in (t)here.
Yes, some of them could be moved. Some even to the potential new If you have a specific suggestion, consider opening an issue/PR or document your idea here:
Well we have to expose them somewhere. Whether as
I agree to a certain extend to it. However,
then we should retain and consider keeping them public. (But that also true for the other modules and one of the reasons, why I'm kind of against #883) |
Don't really see much different between those 2 (3) to be honest.
Sure! Done here: #805 (comment) - once it will get our consensus, I can work on PRs :) It does not make sense to do that if we won't agree on it...
I think Stuff currently in
I listed in #805 what I think make sense to keep public and what not. Lets discuss this over there... As of now renaming |
As in v6 we currently marked things like random.arrayElement to be moved to helpers.arrayElement, I would suggest we will make the renaming / moval of helpers in v7->v8 |
This got stale |
todos: