Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more data for Faker::Friends #1407

Merged
merged 6 commits into from
Oct 14, 2018
Merged

Conversation

JIntrocaso
Copy link
Contributor

Compiled more while adding Friends Faker to .NET port so thought I should make a PR to add it to the original as well.

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled your branch, ran rake and the tests are failing.

Could you fix them?

@vbrazo vbrazo changed the title added more data for friends faker Add more data for Faker::Friends Oct 14, 2018
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vbrazo vbrazo merged commit b1532ea into faker-ruby:master Oct 14, 2018
@JIntrocaso JIntrocaso deleted the new-friends-data branch October 15, 2018 01:27
@mrstebo
Copy link
Contributor

mrstebo commented Oct 16, 2018

Nice one @JIntrocaso 🙌 🎉

davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* added more data for friends faker

* added missing commas between data in friends faker

* Remove unnecessary files

* Run bundle

* Fix rubocop offenses

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants