Add bible entries #1656
Merged
Add bible entries #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi,I submitted a pull request and it was assigned.I was just wondering why it has taken this long to be merged considering that all test passed.
thanks.
Enow B. Mbi,
On Friday, July 12, 2019, 8:08:52 AM GMT+1, Vitor Oliveira <notifications@github.com> wrote:
Assigned #1656 to @enowmbi.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Zeragamba
suggested changes
Aug 13, 2019
Zeragamba
approved these changes
Aug 14, 2019
vbrazo
force-pushed
the
master
branch
3 times, most recently
from
a2a9f17
to
4384168
Compare
Zeragamba
suggested changes
May 17, 2020
| flexible :bible | ||
|
|
||
| class << self | ||
| def character |
There was a problem hiding this comment.
Missing Yard docs for these new methods. Check CONTRIBUTING.md for details
There was a problem hiding this comment.
@Zeragamba, can you verify. 🙏🏾
vbrazo
approved these changes
Dec 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added bible entries allowing users to use quotations, locations, and characters from the bible. Entries are in the religion category. e.g.
Faker::Religion::Bible.location #=> 'Jerusalem'
Faker::Religion::Bible.character #=> 'Jesus'
Faker::Religion::Bible.quote #=> 'Seek ye first the kingdom of God'