-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add YARD docs for all remaining TV Shows #1759
Merged
vbrazo
merged 31 commits into
faker-ruby:master
from
connorshea:yard-docs-5-the-doc-strikes-back
Sep 22, 2019
Merged
Add YARD docs for all remaining TV Shows #1759
vbrazo
merged 31 commits into
faker-ruby:master
from
connorshea:yard-docs-5-the-doc-strikes-back
Sep 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeragamba
approved these changes
Sep 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
What percentage does this bring us up to?
39.74%, I said that in the description :P |
I read code not documentation. :Derp: |
Closed
vbrazo
approved these changes
Sep 22, 2019
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
* Add YARD docs for Faker::Music::UmphreysMcgee * Add YARD docs for Buffy the Vampire Slayer. * Add YARD docs for Aqua Teen Hunger Force. * Add YARD docs for BoJack Horseman. * Add YARD docs for Community. * Add YARD docs for Hey Arnold! * Add YARD docs for Family Guy. * Add YARD docs for Friends. * Add YARD docs for Game of Thrones. * Add YARD docs for How I Met Your Mother. * Add YARD docs for Michael Scott. * Fix some Rubocop warnings. * Add YARD docs for New Girl. * Add YARD docs for Parks and Recreation. * Add YARD docs for Rick and Morty. * Add YARD docs for RuPaul's Drag Race. * Add YARD docs for Seinfeld. * Add YARD docs for Silicon Valley. * Add YARD docs for The Simpsons * Add YARD docs for South Park. * Add YARD docs for Star Trek. * Add YARD docs for Stargate. * Add YARD docs for Stranger Things. * Add YARD docs for The Expanse. * Add YARD docs for The Fresh Prince of Bel-Air. * Add YARD docs for The IT Crowd. * Add YARD docs for The Thick of It. * Add YARD docs for Twin Peaks. * Add YARD docs for The Venture Bros. * Add YARD docs for Dumb and Dumber. * Fix grammar in Star Trek.
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Add YARD docs for Faker::Music::UmphreysMcgee * Add YARD docs for Buffy the Vampire Slayer. * Add YARD docs for Aqua Teen Hunger Force. * Add YARD docs for BoJack Horseman. * Add YARD docs for Community. * Add YARD docs for Hey Arnold! * Add YARD docs for Family Guy. * Add YARD docs for Friends. * Add YARD docs for Game of Thrones. * Add YARD docs for How I Met Your Mother. * Add YARD docs for Michael Scott. * Fix some Rubocop warnings. * Add YARD docs for New Girl. * Add YARD docs for Parks and Recreation. * Add YARD docs for Rick and Morty. * Add YARD docs for RuPaul's Drag Race. * Add YARD docs for Seinfeld. * Add YARD docs for Silicon Valley. * Add YARD docs for The Simpsons * Add YARD docs for South Park. * Add YARD docs for Star Trek. * Add YARD docs for Stargate. * Add YARD docs for Stranger Things. * Add YARD docs for The Expanse. * Add YARD docs for The Fresh Prince of Bel-Air. * Add YARD docs for The IT Crowd. * Add YARD docs for The Thick of It. * Add YARD docs for Twin Peaks. * Add YARD docs for The Venture Bros. * Add YARD docs for Dumb and Dumber. * Fix grammar in Star Trek.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds YARD docs for all remaining TV show fakers (except Doctor Who because I handled that separately #1758) and also
lib/faker/music/umphreys_mcgee.rb
.Once again used my script to do this without as much manual work.
With these additions we're at 39.74% documented.