add Faker::Beer YARD docs #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
connorshea
requested changes
Nov 13, 2019
lib/faker/default/beer.rb
Outdated
| # @example | ||
| # Faker::Beer.name #=> "Pliny The Elder" | ||
| # | ||
| # @faker.version next |
lib/faker/default/beer.rb
Outdated
| def style | ||
| fetch('beer.style') | ||
| end | ||
|
|
||
| ## | ||
| # Produces a random beer hops . |
There was a problem hiding this comment.
Suggested change
| # Produces a random beer hops . | |
| # Produces a random beer hops. |
lib/faker/default/beer.rb
Outdated
| def yeast | ||
| fetch('beer.yeast') | ||
| end | ||
|
|
||
| ## | ||
| # Produces a random beer malts. |
There was a problem hiding this comment.
I think this should be singular?
Suggested change
| # Produces a random beer malts. | |
| # Produces a random beer malt. |
lib/faker/default/beer.rb
Outdated
| def malts | ||
| fetch('beer.malt') | ||
| end | ||
|
|
||
| ## | ||
| # Produces a random beer ibu. |
There was a problem hiding this comment.
Suggested change
| # Produces a random beer ibu. | |
| # Produces a random beer IBU. |
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
* add Faker::Beer YARD docs * add version number * Update beer.rb
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* add Faker::Beer YARD docs * add version number * Update beer.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add YARD docs for Faker::Beer