Add Japanese for Faker::Games::Orverwatch #2275

may-solty · 2021-03-06T08:09:11Z

Add Japanese for Faker::Games::Overwatch.hero
Thank you!

irb(main):001:0> Faker::Config.locale = :ja
=> :ja
irb(main):004:0> Faker::Games::Overwatch.hero
=> "トレーサー"

psibi · 2021-03-06T09:15:48Z

lib/locales/ja.yml

@@ -53,6 +53,9 @@ ja:
      sushi: ["アオヤギ", "アカガイ", "アジ", "アナゴ", "アマエビ", "アワビ", "イカ", "イクラ", "ウナギ", "カキ", "カツオ", "カニ", "カンパチ", "キス", "コハダ", "サーモン", "サザエ", "サバ", "サヨリ", "サワラ", "シマアジ", "シラコ", "スズキ", "タイ", "タコ", "タマゴ", "ノドグロ", "ハマグリ", "ハマチ", "ヒラメ", "ブリ", "ホタテ", "ホタルイカ", "ボタンエビ", "マグロ", "マス", "ミルガイ"]

    games:
+      overwatch:
+        heroes: ["D.Va", "アッシュ", "アナ", "ウィドウメイカー", "ウィンストン", "エコー", "オリーサ", "ゲンジ", "ザリア", "シグマ", "シンメトラ", "ジャンクラット", "ゼニヤッタ", "ソルジャー76", "ソンブラ", "トレーサー", "トールビョーン", "ドゥームフィスト", "ハンゾー", "バスティオン", "バティスト", "ファラ", "ブリギッテ", "マクリー", "マーシー", "メイ", "モイラ", "ラインハルト", "リーパー", "ルシオ", "レッキング・ボール", "ロードホッグ"]


No idea about the locale, but is D.Va intended in the data ?

@psibi Yes, it is. The D.Va is intended in the data. The D.Va is also written as D.Va in Japanese.

psibi · 2021-03-06T14:13:37Z

Thank you!

Add Japanese for Faker::Games::Orverwatch

14dd9d5

psibi reviewed Mar 6, 2021

View reviewed changes

psibi merged commit 677ac8f into faker-ruby:master Mar 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Japanese for Faker::Games::Orverwatch #2275

Add Japanese for Faker::Games::Orverwatch #2275

may-solty commented Mar 6, 2021 •

edited

psibi Mar 6, 2021

may-solty Mar 6, 2021

psibi commented Mar 6, 2021

Add Japanese for Faker::Games::Orverwatch #2275

Add Japanese for Faker::Games::Orverwatch #2275

Conversation

may-solty commented Mar 6, 2021 • edited

psibi Mar 6, 2021

Choose a reason for hiding this comment

may-solty Mar 6, 2021

Choose a reason for hiding this comment

psibi commented Mar 6, 2021

may-solty commented Mar 6, 2021 •

edited