Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bot_user_agent method for generate web crawle's user agents #2477

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

a-chacon
Copy link
Contributor

Issue#

No-Story

Description:

Hello, I added a new method for generate Web Crawler's UserAgents on the Internet Class. I was using this gem on a personal project, and I was looking for this functionality on my tests, but I don't found this, so I made it. This is my first time with a PR on an open project, so if I did something wrong, I hope to let my know for fix it.
I add:

  • bot_user_agent on lib/faker/default/internet.rb
  • Tests on tests/faker/default/test_faker_internet.rb
  • bot_user_agents on lib/locales/en/internet.yml
  • Documentation on doc/default/internet.md

@a-chacon
Copy link
Contributor Author

a-chacon commented Jul 4, 2022

Hello, any feedback about this?

Copy link
Contributor

@thdaraujo thdaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thdaraujo
Copy link
Contributor

thank you!

@thdaraujo thdaraujo merged commit 2333f9e into faker-ruby:master Jul 4, 2022
@a-chacon
Copy link
Contributor Author

a-chacon commented Jul 4, 2022

Thanks to you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants