Fix warning instance variable uninitialized

[akmhmgc]

Summary

Fixed the warning instance variable @flexible_key is not initialized

Other Information

Running the tests, I found warning down below and fix it : )

/faker/lib/faker.rb:191: warning: instance variable @flexible_key not initialized

[thdaraujo]

thanks for reporting this, good catch!

I wonder if we could refactor the usage of flexible to make it more clear. It's a bit obscure right now.

Maybe we should have an attr_reader :flexible_key instead? The advantage is that we wouldn't have to worry about @flexible_key being defined anymore.

The other advantage is that these types of tests here could just check the value of @tester.flexible_key as well, instead of having to access the internal variable:

faker/test/faker/default/test_faker_hobby.rb

Line 11 in cbe6017

flexible_key = @tester.instance_variable_get('@flexible_key')

What do you think?

[thdaraujo]

have you considered the case where @flexible_key is defined, but its value is set to nil?
This would probably raise an error below.

[akmhmgc]

Oh, I forgot about that...

@foo = nil
p 'foo is defined' if defined? @foo
p 'foo is not nil' if @foo
#=> "foo is defined"

As you said, my change raise the error subclass defined even when @flexible_key is set to nil.

[akmhmgc]

@thdaraujo

Maybe we should have an attr_reader :flexible_key instead? The advantage is that we wouldn't have to worry about @flexible_key being defined anymore.

I think it's better way too!!
Please check this when you have a time : )
9c3df0f