add tests for password and fix an edge case

[DeepakRaj228]

Summary

Found an invalid edge case where the password method returns a value.

1. Have added an exception if the min length and max length are 0 in the Faker::Internet.password method.
2. Updated the number range starting from 0.
3. Added tests and covered the following existing flows.

1. min_length must be at least 2 if mix_case: true && special_characters: false
   Faker::Internet.password(min_length: 10, max_length: 20, mix_case: true) #=> "3k5qS15aNmG"
2. min_length must be at least 3 if mix_case: true && special_characters: true
   Faker::Internet.password(min_length: 10, max_length: 20, mix_case: true, special_characters: true) #=> "*%NkOnJsH4"

Test results:

Other Information

[DeepakRaj228]

@stefannibrasil, I have added a few test cases as you mentioned here. Please let me know if there are any other cases that need to be covered.

[stefannibrasil]

This is awesome, thank you so much @DeepakRaj228 🙏

I've left some suggestions/questions, let me know if they make sense.

I think you covered most of them. The only one I can think of now is passing max_length only. Then, with it being less and bigger than min_length.

[DeepakRaj228]

Hey @stefannibrasil thank you for reviewing this :), I have updated and fixed all your review comments and ran the latest test.

[gkunwar]

Awesome work @DeepakRaj228.

I think this PR is ready to merge.

[thdaraujo]

I think the first assertion message is misleading as min and max could be equal.

If that is true, and we can allow min_length == max_length, then we could be a bit more descriptive, as the base case would be:
min_length == 1 && max_length == 1.

Otherwise, min_length <= max_length where min and max are greater than 1. What do you think?

Suggested change

	raise ArgumentError, 'max_length must be more than min_length' if max_length < min_length
	raise ArgumentError, 'min_length and max_length must have at least one character' if(min_length == 0 && max_length == 0)
	raise ArgumentError, 'min_length and max_length must be greater than or equal to one' if min_length < 1 || max_length < 1
	raise ArgumentError, 'min_length must be smaller than or equal to max_length' unless min_length <= max_length

[DeepakRaj228]

@thdaraujo I agree with your point and the above suggestion is even clearer than the current one.

[stefannibrasil]

ohh, thank you @thdaraujo for catching that! 👀

[stefannibrasil]

@DeepakRaj228 thank you for your contribution and flexibility. There are only some rubocop issues to solve, and then this can be merged 🎉

[stefannibrasil]

@DeepakRaj228 you can run rubocop locally to catch the issues before CI: https://github.com/faker-ruby/faker/blob/main/CONTRIBUTING.md#code-style 👀

[DeepakRaj228]

Thanks @stefannibrasil, fixed the error.