Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Has compile_uri_template been removed? #532

Closed
dukedougal opened this issue Apr 23, 2015 · 3 comments · Fixed by #541
Closed

Has compile_uri_template been removed? #532

dukedougal opened this issue Apr 23, 2015 · 3 comments · Fixed by #541
Labels
bug
Milestone
0.3

Comments

@dukedougal
Copy link

I can't see it in the code any more.
@kgriffs
Copy link
Member

kgriffs commented Apr 30, 2015

@dukedougal Looks like it was removed as part of the new router patch. We could bring it back in falcon.routing.util if it's still needed. What do you think?

@kgriffs kgriffs added this to the 0.3 milestone Apr 30, 2015
@kgriffs kgriffs added the bug label Apr 30, 2015
@dukedougal
Copy link
Author

I use it because I built my own routing and it's at the core of my functionality.

kgriffs pushed a commit to kgriffs/falcon that referenced this issue May 5, 2015
fix(routing): Restore compile_uri_template
bca1bd6 
Restore the compile_uri_template function to the routing module to
ensure backwards compatibility with custom routing engines that
rely on it.

Fixes falconry#532
@kgriffs kgriffs mentioned this issue May 5, 2015
Merged
@kgriffs
Copy link
Member

kgriffs commented May 5, 2015

@dukedougal Please test that PR and comment on it to let me know if it works for you. Thanks!

kgriffs pushed a commit that referenced this issue May 8, 2015
fix(routing): Restore compile_uri_template
1644ca5 
Restore the compile_uri_template function to the routing module to
ensure backwards compatibility with custom routing engines that
rely on it.

Fixes #532
@vytas7 vytas7 mentioned this issue Oct 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.3
Development

Successfully merging a pull request may close this issue.

fix(routing): Restore compile_uri_template kgriffs/falcon
2 participants
@dukedougal @kgriffs