feat(api) Add HTTPStatus exception for immediate response #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,45 @@ | |||
| # Copyright 2013 by Rackspace Hosting, Inc. | |||
There was a problem hiding this comment.
Since you created this file, you can put your own name or the name of your employer (depending on your company's IP policy) here instead of Rackspace.
mcm
force-pushed
the
mcmaster/feature_414
branch
from
7c7a0a7
to
4b8b200
Compare
Add an HTTPStatus exception that is handled similarly to HTTPError in terms of hooks and middleware, but does not pass through error handling. Fixes falconry#414
mcm
force-pushed
the
mcmaster/feature_414
branch
from
4b8b200
to
34e89db
Compare
|
|
||
| def test_raise_status_survives_after_hooks(self): | ||
| """ Make sure after hook doesn't overwrite our status """ | ||
| self.api = falcon.API(after=[noop_after_hook]) |
There was a problem hiding this comment.
The global after hook would be expected to overwrite the status. Therefore, it seems like this test should use an after hook that attempts to do so, and ensures it succeeds, as in test_raise_status_runs_process_response.
There was a problem hiding this comment.
L129 tests for this. The GET responder sets HTTP_500, and the after_hook overwrites it. L139 is testing to ensure that if responder raises HTTPStatus, using an after hook doesn't implicitly override the response.
|
Just one comment. Otherwise LGTM. |
|
Thanks! |
kgriffs
added a commit
that referenced
this pull request
Apr 15, 2015
feat(api) Add HTTPStatus exception for immediate response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an HTTPStatus exception that is handled similarly to HTTPError in
terms of hooks and middleware, but does not pass through error handling.
Fixes #414