-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[falcosidekick-ui] Customize initcontainer Docker image #702
[falcosidekick-ui] Customize initcontainer Docker image #702
Conversation
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nlamirault The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@@ -5,6 +5,10 @@ numbering uses [semantic versioning](http://semver.org). | |||
|
|||
Before release 0.1.20, the helm chart can be found in `falcosidekick` [repository](https://github.com/falcosecurity/falcosidekick/tree/master/deploy/helm/falcosidekick). | |||
|
|||
## 0.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``
## 0.9.0 | |
## 0.9.1 |
I know it's not following the semver, but we upgrade the minor at each new version of sidekick or ui, and the patch for this kind of change
@@ -3,7 +3,7 @@ appVersion: 2.29.0 | |||
description: Connect Falco to your ecosystem | |||
icon: https://raw.githubusercontent.com/falcosecurity/falcosidekick/master/imgs/falcosidekick_color.png | |||
name: falcosidekick | |||
version: 0.8.0 | |||
version: 0.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version: 0.9.0 | |
version: 0.8.1 |
@@ -5,6 +5,10 @@ numbering uses [semantic versioning](http://semver.org). | |||
|
|||
Before release 0.1.20, the helm chart can be found in `falcosidekick` [repository](https://github.com/falcosecurity/falcosidekick/tree/master/deploy/helm/falcosidekick). | |||
|
|||
## 0.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``
## 0.9.0 | |
## 0.8.1 |
I know it's not following the semver, but we upgrade the minor at each new version of sidekick or ui, and the patch for this kind of change
The PR #703 contains your change and more, so I preferred to merge it. Thanks for your help. |
What type of PR is this?
/kind feature
/kind chart-release
Any specific area of the project related to this PR?
/area falcosidekick-chart
What this PR does / why we need it:
With actual Helm chart it is not possible to change the Docker registry used by the init Container from Falcosidekick UI.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist