Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added documentation about -A option #840

Merged

Conversation

therealbobo
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind translation

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area videos

What this PR does / why we need it:

This adds some documentation about the -A option as mentioned in the issue #715 .

Which issue(s) this PR fixes:

Fixes #715

Special notes for your reviewer:

Maybe could be a good idea to retrieve automatically the information from the code (with some grep magic?)

Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
@poiana
Copy link

poiana commented Mar 5, 2023

Welcome @therealbobo! It looks like this is your first PR to falcosecurity/falco-website 🎉

@poiana poiana added the size/XL label Mar 5, 2023
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! Just left a comment.

Plus, since this changes will be relled-out in Falco 0.35.0, we need to hold merging this until then to avoid having an inconsistent doc in the 0.34.X website snapshot.

/hold

- `write`
- `writev`
default: |
Only syscalls in *simple_set*:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we are changing this to the sinsp_state_sc_set, plus beware of the newly-introduced base_syscalls and the in-review adaptive_base_syscalls options. My suggestion is to wait for the adaptive syscall selection feature development to be over and then update this section. Reference:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thanks! 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this PR 😄 Sincerely I'm not sure if the new section, about adaptive syscall, is the best place. wdyt?

@jasondellaluce
Copy link
Contributor

/hold up until the next Falco release.

@jasondellaluce
Copy link
Contributor

/assign

Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Jun 7, 2023
@poiana
Copy link

poiana commented Jun 7, 2023

LGTM label has been added.

Git tree hash: 72ec5953f6886ce6b7f71425e9a612f8f08dfe9e

@poiana
Copy link

poiana commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Jun 7, 2023
@FedeDP
Copy link
Contributor

FedeDP commented Jun 7, 2023

/unhold

@poiana poiana merged commit 1b7602e into falcosecurity:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Falco supported events
5 participants