Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the Falco Engine version through the gRPC Version API #1269

Closed
leodido opened this issue Jun 22, 2020 · 6 comments · Fixed by #1507
Closed

Expose the Falco Engine version through the gRPC Version API #1269

leodido opened this issue Jun 22, 2020 · 6 comments · Fixed by #1507

Comments

@leodido
Copy link
Member

leodido commented Jun 22, 2020

Motivation

Rules depend on the Falco Engine version (and the fields a specific version supports) in order to work.

It can be useful to know this version value (and also the fields and rules a version supports) in order to create external tooling (eg., test harness) aware of such knowledge and behaving accordingly.

Feature

Expose the Falco Engine version through the existing gRPC Version API.

Alternatives

Read the Falco Engine version from built files or from source files. Not ideal because it implies a dependency of artifacts on them, imho.

@leodido
Copy link
Member Author

leodido commented Jun 22, 2020

The need for this emerged while reviewing this.

@stale
Copy link

stale bot commented Aug 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Issues labeled "cncf", "roadmap" and "help wanted" will not be automatically closed. Please refer to a maintainer to get such label added if you think this should be kept open.

@stale stale bot added the wontfix label Aug 21, 2020
@leogr
Copy link
Member

leogr commented Aug 24, 2020

/help

@poiana
Copy link

poiana commented Aug 24, 2020

@leogr:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stale stale bot removed the wontfix label Aug 24, 2020
@poiana
Copy link

poiana commented Nov 22, 2020

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@nibalizer
Copy link
Contributor

/assign nibalizer

nibalizer added a commit to nibalizer/falco that referenced this issue Dec 11, 2020
Fixes falcosecurity#1269

Add two new fields in the version service for falco's engine version and
the checksum of all of the fields it understands.

This will require rebuilding/re-releasing all the clients.

Signed-off-by: Spencer Krum <nibz@spencerkrum.com>
nibalizer added a commit to nibalizer/falco that referenced this issue Dec 11, 2020
Fixes falcosecurity#1269

Add two new fields in the version service for falco's engine version and
the checksum of all of the fields it understands.

This will require rebuilding/re-releasing all the clients.

Signed-off-by: Spencer Krum <nibz@spencerkrum.com>
poiana pushed a commit that referenced this issue Dec 15, 2020
Fixes #1269

Add two new fields in the version service for falco's engine version and
the checksum of all of the fields it understands.

This will require rebuilding/re-releasing all the clients.

Signed-off-by: Spencer Krum <nibz@spencerkrum.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants