feature(grpc): Add engine version to version svc #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes falcosecurity#1269 Add two new fields in the version service for falco's engine version and the checksum of all of the fields it understands. This will require rebuilding/re-releasing all the clients. Signed-off-by: Spencer Krum <nibz@spencerkrum.com>
nibalizer
force-pushed
the
engine_version_grpc
branch
from
f81adc2
to
9d6454e
Compare
|
LGTM label has been added. Git tree hash: 6fec5d9bd48950b259109db5a5be801020de5e96
|
|
/milestone 0.27.0 |
leogr
approved these changes
Dec 14, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Updated the release notes to fit our scheme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new fields in the version service for falco's engine version and
the checksum of all of the fields it understands.
This will require rebuilding/re-releasing all the clients.
Signed-off-by: Spencer Krum nibz@spencerkrum.com
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
What this PR does / why we need it:
Adds engine version to version endpoint
Which issue(s) this PR fixes:
Fixes #1269
Special notes for your reviewer:
Tested using the client-go:
Does this PR introduce a user-facing change?: