Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut 0.28.2 release #1653

Closed
7 of 12 tasks
maxgio92 opened this issue May 14, 2021 · 30 comments
Closed
7 of 12 tasks

Cut 0.28.2 release #1653

maxgio92 opened this issue May 14, 2021 · 30 comments
Assignees
Milestone

Comments

@maxgio92
Copy link
Member

maxgio92 commented May 14, 2021

Scheduled to happen: > 2021-05-16, < 2021-06-09

This is a patch release. We can make the release happen as the features are merged.

Release Steps

Process is described in this document: https://github.com/falcosecurity/falco/blob/master/RELEASE.md

Release Blocking Features

Action Items

Open Questions

/milestone 0.28.2
/assign @maxgio92 @leogr @zuc
/kind documentation

@poiana
Copy link

poiana commented May 14, 2021

@maxgio92: The label(s) priority/important-soon cannot be applied, because the repository doesn't have them.

In response to this:

Scheduled to happen: > 2021-05-16, < 2021-06-09

This is a patch release. We can make the release happen as the features are merged.

Release Steps

Process is described in this document: https://github.com/falcosecurity/falco/blob/master/RELEASE.md

Release Blocking Features

#1552

Action Items

  • Update release documentation
  • Changelog update for 0.28.2
  • Meeting-notes
  • Blog
  • Send email to cncf-falco-dev mailing list
  • Announce in Falco slack channel

Open Questions

/milestone 0.28.2
/assign @maxgio92 @leogr
/priority important-soon
/kind documentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link

poiana commented May 14, 2021

@maxgio92: You must be a member of the falcosecurity/maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Falco maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

Scheduled to happen: > 2021-05-16, < 2021-06-09

This is a patch release. We can make the release happen as the features are merged.

Release Steps

Process is described in this document: https://github.com/falcosecurity/falco/blob/master/RELEASE.md

Release Blocking Features

#1552

Action Items

  • Update release documentation
  • Changelog update for 0.28.2
  • Meeting-notes
  • Blog
  • Send email to cncf-falco-dev mailing list
  • Announce in Falco slack channel

Open Questions

/milestone 0.28.2
/assign @maxgio92 @leogr
/priority important-soon
/kind documentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member

leogr commented May 18, 2021

Update:

The last PR for cutting 0.28.2 is ready to be reviewed 👇
#1552

TODO:
Since the driver version changed, we should also update the Driver Build Grid configuration in test-infra

@leogr leogr added this to the 0.28.2 milestone May 18, 2021
@maxgio92
Copy link
Member Author

Thanks @leogr. Updated the checklist in this issue's description.

@maxgio92
Copy link
Member Author

maxgio92 commented May 19, 2021

I'm going to prepare DBG configurations test-infra #398

@maxgio92
Copy link
Member Author

/assign @leogr @maxgio92 @zuc

@poiana
Copy link

poiana commented May 19, 2021

@maxgio92: GitHub didn't allow me to assign the following users: zuc.

Note that only falcosecurity members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @leogr @maxgio92 @zuc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maxgio92 maxgio92 removed their assignment May 19, 2021
@leogr leogr assigned maxgio92 and leogr and unassigned leogr and maxgio92 May 19, 2021
@zuc
Copy link
Member

zuc commented May 19, 2021

hello 👋

@maxgio92
Copy link
Member Author

Hello @zuc!
As discussed @zuc would want to be the release shadow
/assign @zuc

@maxgio92
Copy link
Member Author

Update:

Drivers have been built with success, not published yet (test-infra #398).

@maxgio92
Copy link
Member Author

maxgio92 commented May 21, 2021

Update:

@maxgio92
Copy link
Member Author

Update:

@maxgio92
Copy link
Member Author

Update:

  • (test-infra #398) got merged
  • Waiting to post-merge jobs to publish prebuilt drivers

@maxgio92
Copy link
Member Author

maxgio92 commented May 27, 2021

Update:

We can start the release! (I'll start with pre checks)

@maxgio92
Copy link
Member Author

Update:

@maxgio92
Copy link
Member Author

maxgio92 commented May 27, 2021

Update:

@maxgio92
Copy link
Member Author

Update:

  • community meeting notes #138 merged

@maxgio92
Copy link
Member Author

Update:

  • Release hold

@leogr
Copy link
Member

leogr commented May 28, 2021

We are blocked because cpack is wrongly including gRPC INSTALL targets into packages (note the build-static directory that should not be there) 👇

Screenshot from 2021-05-27 15-58-23

I'm investigating the problem.

@leogr
Copy link
Member

leogr commented May 28, 2021

Also:

  • git tag removed

@maxgio92
Copy link
Member Author

Do you think @leogr this requires a fix on libs building system?

@leogr
Copy link
Member

leogr commented May 28, 2021

Do you think @leogr this requires a fix on libs building system?

It's possible, but I would opt for a temporary patch on the Falco side when importing libs, so we will not need to upgrade the driver version again for this release.

@leogr
Copy link
Member

leogr commented Jun 1, 2021

Patch ready: #1662
Testing in progress 🚀

@leodido
Copy link
Member

leodido commented Jun 1, 2021

Since the Falco 0.29.0 milestone is due on June, 09th...

Would not make more sense to fix this in falcosecurity/libs, update the driver version, and release directly Falco 0.29.0 in 7 days?

@maxgio92
Copy link
Member Author

maxgio92 commented Jun 1, 2021

Cannot the 0.29.0 be postponed? Just a question to have different alternatives in case.

@leodido
Copy link
Member

leodido commented Jun 1, 2021

So, we should postpone an official, and with a fixed cadence, Falco release only to release a hotfix version (0.28.2, patch level) that itself needs to patch the current libs and driver versions at build time?

Doesn't sound very correct to me, but that's just my opinion :)

@leogr
Copy link
Member

leogr commented Jun 1, 2021

Since the Falco 0.29.0 milestone is due on June, 09th...

Would not make more sense to fix this in falcosecurity/libs, update the driver version, and release directly Falco 0.29.0 in 7 days?

Both options are fine to me.

Do we all agree in dismissing the 0.28.2 in favor of 0.29.0 (due date June 9)?

If so, we have to:

  • apply the above fix to falcosecurity/libs
  • update the driver version in Falco
  • update the changelog
  • fix the milestone value for each PR in this release

That's totally fine.

Please confirm!

@maxgio92
Copy link
Member Author

maxgio92 commented Jun 1, 2021

Sorry @leodido I didn't get the point that the 0.29.0 has been actually planned, you're right in my opinion.

In that case I agree with you all to dismiss 0.28.2 in favor of 0.29.0.

@fntlnz
Copy link
Contributor

fntlnz commented Jun 1, 2021

Closing since we agreeed to cut 0.29.0 directly.
/close

@poiana poiana closed this as completed Jun 1, 2021
@poiana
Copy link

poiana commented Jun 1, 2021

@fntlnz: Closing this issue.

In response to this:

Closing since we agreeed to cut 0.29.0 directly.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants