build(cmake/modules): avoid gRCP files to be installed into packages #1662
Conversation
This patch is to be intended as a temporary workaround. The root issue needs to be addressed in `falcosecurity/libs`. A definite solution will be implemented later. Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| -DZLIB_ROOT:STRING=${ZLIB_SRC} | ||
| BUILD_IN_SOURCE 1 | ||
| BUILD_BYPRODUCTS ${GRPC_LIB} ${GRPCPP_LIB} ${GPR_LIB} ${GRPC_LIBRARIES} | ||
| + INSTALL_COMMAND DESTDIR=/ make install |
There was a problem hiding this comment.
N.B. for reviewers:
the resulting installation directory is computed by DESTDIR + CMAKE_INSTALL_PREFIX.
Basically, it forces gRPC installation files to be always installed into the path specified by CMAKE_INSTALL_PREFIX that's set to ${GRPC_SRC}/target (see here).
See also:
leogr
changed the title
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
There was a problem hiding this comment.
I see your point in patching this here to complete the hotfix release of Falco 0.28 line.
But, wouldn't be simpler and more straightforward to fix the thing where it really belongs to (falcosecurity/libs) and cancel this hotfix release since Falco 0.29 is due in 7 days as per milestones?
Yes, a new driver version would be required and 13ec67e (that in this case never made part of an official Falco version) removed... But to me, it would sound all more correct.
Just my 2 cents
|
As we all agree on releasing 0.29.0 directly, I'm closing this and moving the fix to |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
This patch is to be intended as a temporary workaround.
The root issue needs to be addressed in
falcosecurity/libs.A definite solution will be implemented later.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is a hotfix to unblock the current release.
It addresses the issue described in #1653 (comment)
/milestone 0.28.2
Does this PR introduce a user-facing change?: