Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image for event generator deployment yaml #1091

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

mstemm
Copy link
Contributor

@mstemm mstemm commented Mar 12, 2020

I had a bug in #1088 where
the image name for the event generator was pointing to a temporary tag
instead of latest. This switches the image name back to latest.

Signed-off-by: Mark Stemm mark.stemm@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(event-generator): the image used by the event generator deployment to `latest`.

I had a bug in #1088 where
the image name for the event generator was pointing to a temporary tag
instead of latest. This switches the image name back to latest.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
@poiana
Copy link

poiana commented Mar 12, 2020

LGTM label has been added.

Git tree hash: 950467ab68324b5ecfeaaf293b64a78e3e0bf18d

@poiana
Copy link

poiana commented Mar 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, kris-nova, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [fntlnz,kris-nova,leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leodido
Copy link
Member

leodido commented Mar 12, 2020

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Mar 12, 2020
@fntlnz fntlnz closed this Mar 12, 2020
@fntlnz fntlnz reopened this Mar 12, 2020
@poiana poiana merged commit 2126616 into master Mar 12, 2020
@poiana poiana deleted the fix-event-generator-deployment-yaml branch March 12, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants