Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(examples): move /examples to contrib repo #1191

Merged
merged 1 commit into from
May 14, 2020
Merged

Conversation

leogr
Copy link
Member

@leogr leogr commented May 6, 2020

Signed-off-by: Leonardo Grasso me@leonardograsso.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:
As per "Falco Artifacts Scope" proposal 馃憠 #1184

Which issue(s) this PR fixes:

Special notes for your reviewer:
/hold
until:

/milestone 0.23.0

/cc @fntlnz
/cc @leodido
/cc @kris-nova

Does this PR introduce a user-facing change?:

docs(examples): move `/examples` to `contrib` repo

leodido
leodido previously approved these changes May 6, 2020
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Could you please update the release-note block in the PR using the docs type?

@poiana poiana added the lgtm label May 6, 2020
@poiana
Copy link

poiana commented May 6, 2020

LGTM label has been added.

Git tree hash: a6869598248a9c2542fe8971abea94f423dacec4

@poiana poiana added the approved label May 6, 2020
@leogr
Copy link
Member Author

leogr commented May 6, 2020

LGTM thanks!

Could you please update the release-note block in the PR using the docs type?

Done!

fntlnz
fntlnz previously approved these changes May 8, 2020
@leogr
Copy link
Member Author

leogr commented May 13, 2020

/hold cancel

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr dismissed stale reviews from fntlnz and leodido via 376988b May 13, 2020 13:35
@poiana poiana removed the lgtm label May 13, 2020
Copy link
Member Author

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just rebased
LGTM

@poiana poiana removed the approved label May 13, 2020
@poiana poiana added the lgtm label May 13, 2020
@poiana
Copy link

poiana commented May 13, 2020

LGTM label has been added.

Git tree hash: 5cfbc13afd948ea87fcea545826f360e2b075302

@leogr leogr requested a review from fntlnz May 14, 2020 09:07
@poiana poiana merged commit 9242c45 into master May 14, 2020
@poiana poiana deleted the cleanup/examples branch May 14, 2020 10:54
@poiana
Copy link

poiana commented May 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants