feat(proposal): Adding artifacts scope and proposal #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leodido
reviewed
May 4, 2020
leodido
reviewed
May 5, 2020
leodido
reviewed
May 5, 2020
leodido
reviewed
May 5, 2020
leodido
reviewed
May 5, 2020
leodido
reviewed
May 5, 2020
leogr
reviewed
May 5, 2020
leogr
reviewed
May 5, 2020
leogr
reviewed
May 5, 2020
|
I'm going to refine this proposal as discussed privately! |
leogr
force-pushed
the
falco-artifacts-scope
branch
2 times, most recently
from
c8a2f93
to
e817961
Compare
- Highlights scope of Falco - Highlights subprojects and groups evolution - Defines build artifacts - Defines artifact naming convention - Dictates that we take action to make these changes happen Signed-off-by: Kris Nova <kris@nivenly.com>
Signed-off-by: Kris Nova <kris@nivenly.com>
Signed-off-by: Kris Nova <kris@nivenly.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com> As per https://github.com/falcosecurity/falco/pull/1184/files#r420856406
leogr
reviewed
May 6, 2020
leogr
reviewed
May 6, 2020
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
leogr
reviewed
May 11, 2020
leogr
reviewed
May 11, 2020
…t image naming Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
fntlnz
approved these changes
May 11, 2020
leogr
approved these changes
May 11, 2020
|
LGTM label has been added. Git tree hash: 75cf9aad7c97aec07f6cf9a278d629c80c4b1c53
|
leodido
approved these changes
May 11, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leodido, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/honk |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kris Nova kris@nivenly.com
What type of PR is this?
/kind cleanup
/kind design
/kind documentation
Any specific area of the project related to this PR?
/area proposals
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: