Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docker): driverloader to falco-driver-loader #1192

Merged
merged 1 commit into from
May 8, 2020

Conversation

leogr
Copy link
Member

@leogr leogr commented May 6, 2020

Signed-off-by: Leonardo Grasso me@leonardograsso.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:

See #1184

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(docker): add an image that wraps the `falco-driver-loader` with the toolchain

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Please insert a release-note, this rename is very user-facing :)

@poiana
Copy link

poiana commented May 6, 2020

LGTM label has been added.

Git tree hash: 90bcfa7ca18c036a32845bd345df49c35790c7a0

@poiana poiana added the approved label May 6, 2020
@leogr
Copy link
Member Author

leogr commented May 6, 2020

Please insert a release-note, this rename is very user-facing :)

I was already thinking about that but I have had a doubt:
Since the release note added here has not been released yet, does it make sense to have two conflicting release notes in the same release?
Or... should I clean up the old one then put here just a new release note?

I know, it's brain freezing, sorry 🤗

@leogr
Copy link
Member Author

leogr commented May 6, 2020

I just need
/honk
after my previous comment 🤕

@poiana
Copy link

poiana commented May 6, 2020

@leogr:
goose image

In response to this:

I just need
/honk
after my previous comment 🤕

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana merged commit 900a3b5 into master May 8, 2020
@poiana
Copy link

poiana commented May 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana deleted the refactor/docker/driverloader branch May 8, 2020 16:08
@leogr leogr mentioned this pull request May 9, 2020
@leogr leogr added this to the 0.23.0 milestone May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants