Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(docker): remove minimal image #1196

Merged
merged 1 commit into from
May 13, 2020
Merged

update(docker): remove minimal image #1196

merged 1 commit into from
May 13, 2020

Conversation

leogr
Copy link
Member

@leogr leogr commented May 7, 2020

Signed-off-by: Leonardo Grasso me@leonardograsso.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:

As per "Falco Artifacts Scope" proposal 👉 #1184

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

  • There's no reference to it on the web site (except for the changelog part of two blog posts
  • It is not used by integrations nor examples
  • The helm chart does not use it

PS
Since the multi-stage build approach used by this minimal image seems still valid to me, I would propose - in another PR - to refactor the current docker/slim/Dockerfile in the same way but once we have decided the proper naming of these images.

/cc @fntlnz
/cc @kris-nova
/cc @leodido

Does this PR introduce a user-facing change?:

update(docker): remove `minimal` image

@leogr
Copy link
Member Author

leogr commented May 7, 2020

/hold
for #1184

leodido
leodido previously approved these changes May 8, 2020
@poiana poiana added the lgtm label May 8, 2020
@poiana
Copy link

poiana commented May 8, 2020

LGTM label has been added.

Git tree hash: ae5cfbd55fc6daa33e2042eac223a10aab05d09f

@poiana poiana added the approved label May 8, 2020
fntlnz
fntlnz previously approved these changes May 8, 2020
@leodido leodido added this to the 0.23.0 milestone May 8, 2020
@leogr
Copy link
Member Author

leogr commented May 12, 2020

/hold cancel

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr dismissed stale reviews from fntlnz and leodido via cbac1d2 May 13, 2020 06:27
@leogr
Copy link
Member Author

leogr commented May 13, 2020

Rebased.

@poiana poiana added the lgtm label May 13, 2020
@poiana
Copy link

poiana commented May 13, 2020

LGTM label has been added.

Git tree hash: b81a7c94ce6288a76ee79324b7da12a981b40da6

@leogr
Copy link
Member Author

leogr commented May 13, 2020

/honk
🦅

@poiana
Copy link

poiana commented May 13, 2020

@leogr:
goose image

In response to this:

/honk
🦅

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana merged commit 0c4074b into master May 13, 2020
@poiana
Copy link

poiana commented May 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana deleted the cleanup/docker/minimal branch May 13, 2020 08:39
@JPLachance
Copy link
Contributor

I just found this PR and it makes me a little bit sad.

This image was a cool experiment made @mfdii. The goal was to reduce the amount of packages shipped in the Falco container image to easily pass container images scanners like Clair or Snyk.

A quick scan with Snyk of the falcosecurity/falco:0.22.1-slim Docker image reveals there are 103 known vulnerabilities in the image. The "minimal" image fixed that.

@leogr
Copy link
Member Author

leogr commented May 13, 2020

Hey @JPLachance
this PR was just an intermediate step, the content of the old minimal will be re-published as falcosecurity/falco-no-driver as proposed here https://github.com/falcosecurity/falco/blob/master/proposals/20200506-artifacts-scope-part-2.md#images

I believe we can do this before the next release.
So the only breaking change will be just to change the image name.
WDYT?

@JPLachance
Copy link
Contributor

Great then! I'll be happy to test te new image once we will have a way to load the probe :D

#897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants