Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump b64 to v2.0.0.1 #1441

Merged
merged 2 commits into from
Oct 13, 2020
Merged

build: bump b64 to v2.0.0.1 #1441

merged 2 commits into from
Oct 13, 2020

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Oct 13, 2020

Signed-off-by: Lorenzo Fontana fontanalorenz@gmail.com

What type of PR is this?

/kind cleanup

/area build

What this PR does / why we need it:

libb64, a dependency that we use for base64 encoding/decoding was having an issue on armv7.

Reported by: @alexellis

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

build: bump b64 to v2.0.0.1

Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>
leodido
leodido previously approved these changes Oct 13, 2020
@poiana
Copy link

poiana commented Oct 13, 2020

LGTM label has been added.

Git tree hash: e343140bff42b71ff2591d286246347b72dcacaf

@alexellis
Copy link

I'm getting this error:

pi@k4s-1:~/falco/build $ make
[  0%] Performing update step for 'string-view-lite'
[  0%] No configure step for 'string-view-lite'
[  0%] No build step for 'string-view-lite'
[  0%] Performing install step for 'string-view-lite'
[  1%] Completed 'string-view-lite'
[  3%] Built target string-view-lite
[  7%] Built target tbb
[  8%] Performing build step for 'b64'
In file included from /usr/include/stdio.h:33,
                 from c-example1.c:21:
/usr/lib/gcc/arm-linux-gnueabihf/8/include/stddef.h:216:23: error: conflicting types for ‘size_t’
 typedef __SIZE_TYPE__ size_t;
                       ^~~~~~
In file included from ../include/b64/cencode.h:11,
                 from c-example1.c:18:
../include/b64/ccommon.h:20:27: note: previous declaration of ‘size_t’ was here
     typedef unsigned long size_t;
                           ^~~~~~
make[4]: *** [<builtin>: c-example1] Error 1
make[3]: *** [Makefile:8: all_examples] Error 2
make[2]: *** [CMakeFiles/b64.dir/build.make:114: b64-prefix/src/b64-stamp/b64-build] Error 2
make[1]: *** [CMakeFiles/Makefile2:147: CMakeFiles/b64.dir/all] Error 2
make: *** [Makefile:152: all] Error 2

Arch/OS:

pi@k4s-1:~/falco/build $ uname -a
Linux k4s-1 4.19.75-v7l+ #1270 SMP Tue Sep 24 18:51:41 BST 2019 armv7l GNU/Linux
pi@k4s-1:~/falco/build $ cat /etc/os-release 
PRETTY_NAME="Raspbian GNU/Linux 10 (buster)"
NAME="Raspbian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"

This version includes a fix so that it does not include the headers
for size_t twice.

Signed-off-by: Lorenzo Fontana <fontanalorenz@gmail.com>
@fntlnz
Copy link
Contributor Author

fntlnz commented Oct 13, 2020

/cc @leodido
/cc @leogr

@poiana poiana requested review from leodido and leogr October 13, 2020 11:17
@leogr leogr added this to the 0.27.0 milestone Oct 13, 2020
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@poiana
Copy link

poiana commented Oct 13, 2020

LGTM label has been added.

Git tree hash: 6a4c7468bd7bc3af3bb1b6e008ce2f6e087b03a2

@poiana
Copy link

poiana commented Oct 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 0a33f55 into master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants