fix(userspace/engine): free formatters, if any #1447
Conversation
|
/milestone 0.27.0 |
Previously, formatters were freed by LUA code when re-opening outputs. Since now, outputs are not controlling anymore the falco_formats class (see #1412), we just free formatters only if were already initialized. That is needed when the engine restarts (see #1446). By doing so, we also ensure that correct inspector instance is set to the formatter cache. Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
leogr
force-pushed
the
fix/free-formatters
branch
from
c0f3b5a
to
ee13006
Compare
leogr
changed the title
|
Ready for review. Thanks, @leodido for the suggestions. |
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com> Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
leogr
force-pushed
the
fix/free-formatters
branch
from
ee13006
to
b2a2623
Compare
|
LGTM label has been added. Git tree hash: fa5bb6bede04d5d38bd6cd0dd4d7b23035ec8275
|
|
We can probably use abseil: https://github.com/abseil/abseil-cpp |
|
Putting an hold since this is blocking the merge queue. Feel free to remove once it's approved by two maintainers. /hold |
|
/cc @leodido |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel 🥳 |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Previously, formatters were freed by LUA code when re-opening outputs.
Since now, outputs are not controlling anymore the falco_formats class (see #1412), we just free formatters only if were already initialized.
That is needed when the engine restarts (see #1446).
By doing so, we also ensure that the correct inspector instance is set to the formatter cache.
Which issue(s) this PR fixes:
Fixes #1446
Special notes for your reviewer:
Does this PR introduce a user-facing change?: