Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make our integration tests report clear steps for CircleCI UI #1473

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Nov 5, 2020

inspection via collect test data [0]

[0] https://circleci.com/docs/2.0/collect-test-data/

Signed-off-by: Lorenzo Fontana lo@linux.com

What type of PR is this?

/kind cleanup

/kind documentation

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana poiana requested review from krisnova and mfdii November 5, 2020 13:17
@poiana poiana added the size/XS label Nov 5, 2020
@fntlnz fntlnz changed the title build: make our integration tests report clear steps for circleCI UI build: make our integration tests report clear steps for CircleCI UI Nov 5, 2020
@leodido
Copy link
Member

leodido commented Nov 5, 2020

/milestone 0.27.0

@poiana poiana added this to the 0.27.0 milestone Nov 5, 2020
inspection via collect test data [0]

[0] https://circleci.com/docs/2.0/collect-test-data/

Signed-off-by: Lorenzo Fontana <lo@linux.com>
leogr
leogr previously approved these changes Nov 5, 2020
@poiana poiana added the lgtm label Nov 5, 2020
@poiana
Copy link

poiana commented Nov 5, 2020

LGTM label has been added.

Git tree hash: ffb79763c5a79bb5fff5ba010e45017aab56d3f4

@poiana poiana added the approved label Nov 5, 2020
Co-Authored-By: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Lorenzo Fontana <lo@linux.com>
@poiana poiana added the lgtm label Nov 5, 2020
@poiana
Copy link

poiana commented Nov 5, 2020

LGTM label has been added.

Git tree hash: aaa798e10735a31cbc0ae2410f2abd43f2f9a0e1

@poiana poiana added the approved label Nov 5, 2020
@fntlnz
Copy link
Contributor Author

fntlnz commented Nov 5, 2020

W00t!
image

@poiana
Copy link

poiana commented Nov 5, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit f5c1e7c into master Nov 5, 2020
@poiana poiana deleted the ci/xunit-report-circleci branch November 5, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants