publish packages to S3 (download.falco.org) #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leogr
force-pushed
the
build/publish-pkg-on-s3
branch
from
3be8ab6
to
fcbc120
Compare
|
Update: I did some tests in a simulated environment:
Early feedback is welcome. |
fntlnz
reviewed
Mar 12, 2021
leogr
force-pushed
the
build/publish-pkg-on-s3
branch
from
04d8ae3
to
3d462d1
Compare
|
Update: |
|
|
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
leogr
force-pushed
the
build/publish-pkg-on-s3
branch
from
3d462d1
to
b47a256
Compare
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
leogr
changed the title
fntlnz
approved these changes
Mar 25, 2021
|
LGTM label has been added. Git tree hash: d6034ccca6f5247e0178feb667e58dd36c18a896
|
leodido
reviewed
Mar 26, 2021
| jfrog bt u /build/release/falco-${FALCO_VERSION}-x86_64.deb falcosecurity/deb-dev/falco/${FALCO_VERSION} stable/ --deb stable/main/amd64 --user poiana --key ${BINTRAY_SECRET} --publish --override | ||
| yum update -y | ||
| yum install createrepo gpg -y | ||
| echo $GPG_KEY | base64 -d | gpg --import |
There was a problem hiding this comment.
Let's remember in the future (when we'll move these jobs to ProwJobs) that echo -e $GPG_KEY works ok (no need to base64 encode/decode).
leodido
reviewed
Mar 26, 2021
leodido
reviewed
Mar 26, 2021
leodido
reviewed
Mar 26, 2021
leodido
reviewed
Mar 26, 2021
leodido
reviewed
Mar 26, 2021
leodido
reviewed
Mar 26, 2021
leodido
reviewed
Mar 26, 2021
| | rpm | [][1] | [][2] | | ||
| | deb | [][3] | [][4] | | ||
| | binary | [][5] | [][6] | | ||
| | rpm | [][1] | [][2] | |
leodido
reviewed
Mar 26, 2021
leodido
reviewed
Mar 26, 2021
leodido
approved these changes
Mar 26, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
leogr
added a commit
that referenced
this pull request
Mar 26, 2021
Applying suggestions from #1577 Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com> Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
leogr
added a commit
that referenced
this pull request
Mar 26, 2021
Applying suggestions from #1577 Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com> Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
leogr
added a commit
that referenced
this pull request
Mar 29, 2021
Applying suggestions from #1577 Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com> Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
leogr
added a commit
that referenced
this pull request
Mar 29, 2021
Applying suggestions from #1577 Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com> Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
poiana
pushed a commit
that referenced
this pull request
Apr 7, 2021
Applying suggestions from #1577 Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com> Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
poiana
pushed a commit
that referenced
this pull request
Apr 7, 2021
Applying suggestions from #1577 Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com> Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
This PR introduces scripts to deal with updates of Debian and RPM repositories and modify CI jobs to publish packages (ie.
bin-dev,deb-dev,rpm-dev,bin,deb,rpm) to our S3 bucket which serves those files at https://download.falco.org/Which issue(s) this PR fixes:
Fixes #1567
Special notes for your reviewer:
If this works as expected, a follow-up PR will update the configuration to publish stable packages too (ie.bin,deb,rpm) in the same way.I'm confident that scripts work as expected, so I decided to include the stable packages too in this PR. A follow-up PR might come in case of unexpected issues.
The artifact cleanup job has been disabled since it is intended to work with Bintray only. If needed, we can refactor or clean up it in a follow-up PR.
Does this PR introduce a user-facing change?: