Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(.circleci): tar must be present in the image #1594

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

leogr
Copy link
Member

@leogr leogr commented Mar 27, 2021

What type of PR is this?
/kind bug

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Since amazon/aws-cli does not include the tar util (which must be present in the image, as per CircleCI requirement) we are switching from amazon/aws-cli to centos.

That should fix the broken CI job (see
https://app.circleci.com/pipelines/github/falcosecurity/falco/1391/workflows/c1e1bc39-f008-4644-b8bf-45d1105e1978/jobs/11263)
and complete #1577 (I hope 😸 ).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/milestone 0.28.0
/cc @leodido
/cc @fntlnz

Does this PR introduce a user-facing change?:

NONE

@leogr
Copy link
Member Author

leogr commented Mar 29, 2021

/close
closing and reopening to trigger the CI

@poiana poiana closed this Mar 29, 2021
@poiana
Copy link

poiana commented Mar 29, 2021

@leogr: Closed this PR.

In response to this:

/close
closing and reopening to trigger the CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr
Copy link
Member Author

leogr commented Mar 29, 2021

/reopen

@poiana poiana reopened this Mar 29, 2021
@poiana
Copy link

poiana commented Mar 29, 2021

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana added the size/S label Mar 29, 2021
Since `amazon/aws-cli` does not include the tar util (which must be present in the image, as per CircleCI requirement) we are switching from `amazon/aws-cli` to `centos`.

See
https://app.circleci.com/pipelines/github/falcosecurity/falco/1391/workflows/c1e1bc39-f008-4644-b8bf-45d1105e1978/jobs/11263

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr force-pushed the fix/publish-packages-jobs branch from 3d8c113 to b34031f Compare March 29, 2021 08:38
@poiana
Copy link

poiana commented Mar 29, 2021

LGTM label has been added.

Git tree hash: 7878db7cda12d479aa46753c8e236defcf71c323

@poiana
Copy link

poiana commented Mar 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit f2c12bb into master Mar 29, 2021
@poiana poiana deleted the fix/publish-packages-jobs branch March 29, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants