Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression test for malformed k8s audit input (FAL-01-003) #1624

Merged
merged 2 commits into from
Apr 21, 2021

Conversation

leodido
Copy link
Member

@leodido leodido commented Apr 19, 2021

What type of PR is this?

/kind documentation

/kind feature

Any specific area of the project related to this PR?

/area tests

What this PR does / why we need it:

This PR adds a regression test for FAL-01-003 (see audit).

The rationale is: avoid that such an issue inadvertently happens again in the future.

Which issue(s) this PR fixes:

Refs #759

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido
Copy link
Member Author

leodido commented Apr 19, 2021

/milestone 0.28.1

@poiana poiana added this to the 0.28.1 milestone Apr 19, 2021
@leodido
Copy link
Member Author

leodido commented Apr 19, 2021

/cc @fntlnz
/cc @leogr

@poiana poiana requested review from fntlnz and leogr April 19, 2021 12:53
@poiana
Copy link

poiana commented Apr 19, 2021

LGTM label has been added.

Git tree hash: 3560dbe1f36d1bd41f9a3f20868aacba69b4aa2e

@poiana
Copy link

poiana commented Apr 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 6e94c37 into master Apr 21, 2021
@poiana poiana deleted the update/fal-01-003-regression-test branch April 21, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants